Skip to content

682 Add support for asynchronous workflow test execution and SSE streaming #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivicac merged 7 commits into from
Dec 30, 2025
Merged

682 Add support for asynchronous workflow test execution and SSE streaming #3816

ivicac merged 7 commits into from
Dec 30, 2025

Conversation

@ivicac
Copy link
Contributor

@ivicac ivicac commented Dec 29, 2025

  • 682 Update endpoints
  • 682 Generate
  • 682 Add support for asynchronous workflow test execution and SSE streaming
  • 682 SF, spotbugs

@ivicac ivicac changed the title 682 server 682 Add support for asynchronous workflow test execution and SSE streaming Dec 29, 2025
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for asynchronous workflow test execution with Server-Sent Events (SSE) streaming, enabling real-time progress monitoring and control of workflow test runs.

Key Changes:

  • Introduced asynchronous workflow test execution with start/await pattern replacing synchronous execution
  • Added SSE streaming endpoints for real-time event broadcasting (job status, task progress, errors)
  • Implemented event listener infrastructure using Caffeine caches for job lifecycle monitoring
  • Added stop/attach capabilities for workflow test runs

Reviewed changes

Copilot reviewed 20 out of 25 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
WorkflowTestApiController.java Refactored to support SSE streaming with new endpoints for starting, stopping, and attaching to workflow tests; manages emitters and pending events with Caffeine caches
WorkflowTestFacade.java & WorkflowTestFacadeImpl.java Added async methods (startTestWorkflow, awaitTestResult, stopTest) and event listener registration methods; refactored testWorkflow to use new execution pattern
JobTestExecutor.java Refactored execute method to use start/await pattern; added comprehensive listener registration methods; removed direct JobService dependency
JobSyncExecutor.java Added event listener support with Caffeine caches; introduced new public methods for async job execution (startJob, awaitJob, stopJob); refactored event handling to notify registered listeners
WorkflowTestFacadeTest.java Added comprehensive test coverage for new async execution methods and listener functionality
WorkflowTestApiControllerTest.java Added extensive tests for SSE streaming, stop/attach functionality, and event buffering behavior
JobSyncExecutorTest.java New test file covering listener notifications and job lifecycle management
openapi.yaml Updated API specification to reflect new SSE endpoints (commented out) and stop endpoint
*.gradle.kts Added Caffeine cache dependency to support listener caching infrastructure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac ivicac force-pushed the 682_server branch 2 times, most recently from 25f085c to dabfe60 Compare December 29, 2025 10:30
@ivicac ivicac requested a review from Copilot December 29, 2025 10:31
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 25 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac ivicac requested a review from Copilot December 29, 2025 13:31
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 26 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac ivicac requested a review from Copilot December 29, 2025 14:50
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 26 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac ivicac requested a review from Copilot December 29, 2025 15:34
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 26 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac ivicac requested a review from Copilot December 29, 2025 16:18
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 26 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac ivicac requested a review from Copilot December 29, 2025 18:53
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 26 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac ivicac requested a review from Copilot December 29, 2025 19:19
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 26 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac ivicac requested a review from Copilot December 29, 2025 21:20
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 26 changed files in this pull request and generated 12 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac
682 Fix potential race condition where the future is cancelled before…
b80fc99 
… 'awaitTestResult' completes, which could leave resources in an inconsistent state
@ivicac ivicac requested a review from Copilot December 29, 2025 21:53
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 26 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivicac ivicac force-pushed the 682_server branch 2 times, most recently from 3898b29 to 393f391 Compare December 29, 2025 22:13
@ivicac ivicac requested a review from Copilot December 29, 2025 22:13
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 26 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 30, 2025

Quality Gate Passed Quality Gate passed for 'server'

Issues
36 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ivicac ivicac merged commit 983b6a4 into master Dec 30, 2025
7 checks passed
@ivicac ivicac deleted the 682_server branch December 30, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@matijapetanjek matijapetanjek Awaiting requested review from matijapetanjek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivicac