Skip to content

adding gender-specific ordinals to locales-ar.xml#421

Open
MazenAmria wants to merge 2 commits intocitation-style-language:masterfrom
MazenAmria:master
Open

adding gender-specific ordinals to locales-ar.xml#421
MazenAmria wants to merge 2 commits intocitation-style-language:masterfrom
MazenAmria:master

Conversation

@MazenAmria
Copy link

CSL Locales Pull Request Template

You're about to create a pull request to the CSL locales repository.
If you haven't done so already, see http://docs.citationstyles.org/en/stable/translating-locale-files.html for instructions on how to translate CSL locale files, and https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md on how to submit your changes.
In addition, please fill out the pull request template below.

Description

Briefly describe the changes you're proposing.

Checklist

  • Check that you're listed as a <translator> in the <info> block at the beginning of the file.
  • Check that you've updated the date under <updated> in the <info> block. Be sure to preserve the original date-time formatting (for example, 2025-09-22T22:06:38+00:00)
  • If possible, please include references to dictionaries, style guides, or similar that inform your translations (see the en_US locale for examples). This helps us to keep locales up to date over time.

Copy link
Member

@bwiernik bwiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One correction to make

locales-ar.xml Outdated
<term name="long-ordinal-08">الثامن</term>
<term name="long-ordinal-09">التاسع</term>
<term name="long-ordinal-10">العاشر</term>
<term name="long-ordinal-01" gender="masculine">الأول</term>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<term name="long-ordinal-01" gender="masculine">الأول</term>
<term name="long-ordinal-01" gender-form="masculine">الأول</term>

Please make this change to all the ordinal terms. The nouns stay "gender"

@MazenAmria
Copy link
Author

@bwiernik I've fixed the problem that you mentioned, but it fails with a different error now. I'm not sure if the scheme allows specifying different gender for single and multiple, I think that's the problem.

@adam3smith
Copy link
Member

Yes, that is the problem. You can only set gender on term, not on single/multiple. I'd pick the gender for multiple, which is much more common for the term

@MazenAmria
Copy link
Author

Yes, that is the problem. You can only set gender on term, not on single/multiple. I'd pick the gender for multiple, which is much more common for the term

I can only think of usecases with the singular form, like "1st ed" or "3rd print".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants