Skip to content

[GYR1-843] Add consents to the DIY flow - email portions#6173

Open
spompea-cfa wants to merge 14 commits intomainfrom
gyr1-843-improve-consent-practices-add-diy-consent-flow
Open

[GYR1-843] Add consents to the DIY flow - email portions#6173
spompea-cfa wants to merge 14 commits intomainfrom
gyr1-843-improve-consent-practices-add-diy-consent-flow

Conversation

@spompea-cfa
Copy link
Contributor

@spompea-cfa spompea-cfa commented Jan 29, 2026

Link to Jira issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

GYR1-843 has been split a couple times; the overall goal has been to enhance the
DIY flow (namespace DIY::) like so:

  • GYR1-915 update consent language (main and DIY flows)
  • GYR1-843 Add Notification Preference page with Email checkbox (DIY)
  • GYR1-??? Similar to above but for cell phones (SMS) (DIY)

The new screens should look like their counterparts in the main VITA intake flow
(namespace Questions::).

Regarding SMS/texts:

  • Here, unlike the main intake flow, there are no email or sms/text verification steps.
  • An SMS confirmation message might still be sent (future ticket) TBD

So, at this point, for this ticket, the main bits are:

  • supporting underlying code (e.g., in the DIY base_controller, etc.)
  • notification_preference controller, with just an 'Email' checkbox (the 'Text'
    checkbox is hidden for now)
  • the new email_address controller -- a form to collect an email address.

A comment about an oddity that you might notice here: in addition to the new
screen added in this PR, the initial DIY screen ("File Yourself") also already
collects an email address (and, also, email_address is a required field -- a
legacy config). A follow-up ticket, 877, will remove/change both of these legacy
aspects.

How to test?

Follow this clickpath:

  • home page
  • click File Myself Get Started
  • click Yes I Qualify
  • Fill out the File Yourself form) and submit
  • Choose the 'Email' checkbox and submit
  • Fill out the Email Address form and subit
  • Ensure you successfully arrive at the "Get support while you file on your
    own!" page.

Screenshots (for visual changes)

Screenshot 2026-02-12 at 2 05 48 AM Screenshot 2026-02-12 at 2 05 59 AM

@spompea-cfa spompea-cfa force-pushed the gyr1-843-improve-consent-practices-add-diy-consent-flow branch from 6a49d44 to 6b30df1 Compare January 30, 2026 03:16
@github-actions
Copy link

Heroku app: https://gyr-review-app-6173-d33e594e8023.herokuapp.com/
View logs: heroku logs --app gyr-review-app-6173 (optionally add --tail)

@spompea-cfa spompea-cfa changed the title [draft] [GYR1-843] Improve consent practices (Add DIY consent flow) [draft] [GYR1-843] Improve consent practices (Add DIY consent & contact info flow) Jan 30, 2026
@@ -0,0 +1,20 @@
module Diy
class DiyNotificationPreferenceController < BaseController
Copy link
Contributor

@tahsinaislam tahsinaislam Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can add before_action :require_diy_intake like the ContinueToFsaController so it redirects to the first question

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok great thanks @tahsinaislam !

@spompea-cfa spompea-cfa force-pushed the gyr1-843-improve-consent-practices-add-diy-consent-flow branch from cb13ed4 to 69a76ee Compare February 6, 2026 07:45
@spompea-cfa spompea-cfa changed the title [draft] [GYR1-843] Improve consent practices (Add DIY consent & contact info flow) [draft] [GYR1-843] Improve consent practices (Add DIY consent & contact info flow - email portions) Feb 12, 2026
@spompea-cfa spompea-cfa changed the title [draft] [GYR1-843] Improve consent practices (Add DIY consent & contact info flow - email portions) [GYR1-843] Add consents to the DIY flow - email portions Feb 12, 2026
@spompea-cfa spompea-cfa force-pushed the gyr1-843-improve-consent-practices-add-diy-consent-flow branch from 7757a9f to 9bfd94f Compare February 12, 2026 06:46
@spompea-cfa spompea-cfa marked this pull request as ready for review February 12, 2026 07:15
Copy link
Contributor

@tahsinaislam tahsinaislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants