[GYR1-843] Add consents to the DIY flow - email portions#6173
Open
spompea-cfa wants to merge 14 commits intomainfrom
Open
[GYR1-843] Add consents to the DIY flow - email portions#6173spompea-cfa wants to merge 14 commits intomainfrom
spompea-cfa wants to merge 14 commits intomainfrom
Conversation
6a49d44 to
6b30df1
Compare
|
Heroku app: https://gyr-review-app-6173-d33e594e8023.herokuapp.com/ |
| @@ -0,0 +1,20 @@ | |||
| module Diy | |||
| class DiyNotificationPreferenceController < BaseController | |||
Contributor
There was a problem hiding this comment.
I think you can add before_action :require_diy_intake like the ContinueToFsaController so it redirects to the first question
cb13ed4 to
69a76ee
Compare
7757a9f to
9bfd94f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira issue
Is PM acceptance required? (delete one)
What was done?
GYR1-843 has been split a couple times; the overall goal has been to enhance the
DIY flow (namespace
DIY::) like so:The new screens should look like their counterparts in the main VITA intake flow
(namespace
Questions::).Regarding SMS/texts:
So, at this point, for this ticket, the main bits are:
checkbox is hidden for now)
A comment about an oddity that you might notice here: in addition to the new
screen added in this PR, the initial DIY screen ("File Yourself") also already
collects an email address (and, also,
email_addressis a required field -- alegacy config). A follow-up ticket, 877, will remove/change both of these legacy
aspects.
How to test?
Follow this clickpath:
own!" page.
Screenshots (for visual changes)