ui diff replay: remove unused frame_data list for individual frame display

[TheSecurityDev]

This appears to be something that could be used for displaying individual thumbnails of the diff frames, but for now it's not used and makes things more complex.

[github-actions]

mici raylib UI Preview

✅ Videos are identical! View Diff Report

[Copilot]

Pull request overview

This PR simplifies the UI diff replay HTML report generator by removing an unused mechanism for embedding per-frame thumbnails as base64 data URLs, reducing complexity in the diff analysis pipeline.

Changes:

• Remove frame_to_data_url() and its base64 dependency.
• Stop building/returning frame_data from find_differences() and update callers accordingly.
• Update generate_html_report() signature to drop the unused frame_data parameter.

Comments suppressed due to low confidence (1)

selfdrive/ui/tests/diff/diff.py:76

• generate_html_report builds chunks/current_chunk from different_frames, but the resulting chunks is never used in the generated HTML. This is dead code that adds complexity; consider removing the chunk-building block or wiring it into the report output.

  chunks = []
  if different_frames:
    current_chunk = [different_frames[0]]
    for i in range(1, len(different_frames)):
      if different_frames[i] == different_frames[i - 1] + 1:
        current_chunk.append(different_frames[i])
      else:
        chunks.append(current_chunk)
        current_chunk = [different_frames[i]]
    chunks.append(current_chunk)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

find_differences() always returns a (different_frames, total_frames) tuple (or raises on failure), so the if different_frames is None: branch is unreachable. Consider removing this check (and associated sys.exit(1)) or changing find_differences() to return None explicitly on failure if that’s intended.

Suggested change

	if different_frames is None:
	sys.exit(1)

[TheSecurityDev]

Probably should be removed but not important or relevant to this PR

[github-actions]

raylib UI Preview

All Screenshots