Skip to content

ui diff replay: remove unused frame_data list for individual frame display #37117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeebshihadeh merged 1 commit into from
Feb 7, 2026
Merged

ui diff replay: remove unused frame_data list for individual frame display #37117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions selfdrive/ui/tests/diff/diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import sys
import subprocess
import tempfile
import base64
import webbrowser
import argparse
from pathlib import Path
Expand All @@ -25,12 +24,6 @@ def compare_frames(frame1_path, frame2_path):
return result.returncode == 0


def frame_to_data_url(frame_path):
with open(frame_path, 'rb') as f:
data = f.read()
return f"data:image/png;base64,{base64.b64encode(data).decode()}"


def create_diff_video(video1, video2, output_path):
"""Create a diff video using ffmpeg blend filter with difference mode."""
print("Creating diff video...")
Expand Down Expand Up @@ -60,20 +53,16 @@ def find_differences(video1, video2):

print(f"Comparing {len(frames1)} frames...")
different_frames = []
frame_data = []

for i, (f1, f2) in enumerate(zip(frames1, frames2, strict=False)):
is_different = not compare_frames(f1, f2)
if is_different:
different_frames.append(i)

if i < 10 or i >= len(frames1) - 10 or is_different:
frame_data.append({'index': i, 'different': is_different, 'frame1_url': frame_to_data_url(f1), 'frame2_url': frame_to_data_url(f2)})

return different_frames, frame_data, len(frames1)
return different_frames, len(frames1)


def generate_html_report(video1, video2, basedir, different_frames, frame_data, total_frames):
def generate_html_report(video1, video2, basedir, different_frames, total_frames):
chunks = []
if different_frames:
current_chunk = [different_frames[0]]
Expand Down Expand Up @@ -177,14 +166,14 @@ def main():
diff_video_path = os.path.join(os.path.dirname(args.output), DIFF_OUT_DIR / "diff.mp4")
create_diff_video(args.video1, args.video2, diff_video_path)

different_frames, frame_data, total_frames = find_differences(args.video1, args.video2)
different_frames, total_frames = find_differences(args.video1, args.video2)

if different_frames is None:
sys.exit(1)

Comment on lines 171 to 173
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find_differences() always returns a (different_frames, total_frames) tuple (or raises on failure), so the if different_frames is None: branch is unreachable. Consider removing this check (and associated sys.exit(1)) or changing find_differences() to return None explicitly on failure if that’s intended.

Suggested change
if different_frames is None:
sys.exit(1)

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@TheSecurityDev TheSecurityDev Feb 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be removed but not important or relevant to this PR

print()
print("Generating HTML report...")
html = generate_html_report(args.video1, args.video2, args.basedir, different_frames, frame_data, total_frames)
html = generate_html_report(args.video1, args.video2, args.basedir, different_frames, total_frames)

with open(DIFF_OUT_DIR / args.output, 'w') as f:
f.write(html)
Expand Down
Loading