KNET-18079: Migrate reload4j (log4j1) to log4j2

[shubh-ranade]

• AK upgraded to log4j2: KAFKA-9366: Upgrade log4j to log4j2 apache/kafka#17373
• log4j2.yaml files were generated by first converting log4j.properties to XML using Apache log4j migration tool, and then converting xml to yaml
• Added an explicit dependency following https://logging.apache.org/log4j/2.x/manual/configuration.html#configuration-factories

[confluent-cla-assistant]

🎉 All Contributor License Agreements have been signed. Ready to merge.
_{Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.}

[Copilot]

Pull Request Overview

This PR migrates the project’s logging framework from slf4j to Log4j2 in accordance with the upgrade in log4j2. The changes primarily update import statements and logger instantiations across several modules.

Reviewed Changes

Copilot reviewed 29 out of 33 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
kafka-rest/src/main/java/io/confluent/kafkarest/response/StreamingResponse.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/resources/AsyncResponses.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/requestlog/CustomLog.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/converters/ProtobufConverter.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/converters/JsonSchemaConverter.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/converters/AvroConverter.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/controllers/ReplicaManagerImpl.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/controllers/ProduceControllerImpl.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/controllers/PartitionManagerImpl.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/controllers/ConsumerLagManagerImpl.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/controllers/ConsumerGroupLagSummaryManagerImpl.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/common/KafkaFutures.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/KafkaRestMain.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/KafkaRestConfig.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/KafkaRestApplication.java	Updated logger imports and instantiation
kafka-rest/src/main/java/io/confluent/kafkarest/DefaultKafkaRestContext.java	Updated logger imports and instantiation

Files not reviewed (4)

• checkstyle/import_control.xml: Language not supported
• config/log4j.properties: Language not supported
• config/log4j2.xml: Language not supported
• kafka-rest/pom.xml: Language not supported

Comments suppressed due to low confidence (1)

kafka-rest/src/main/java/io/confluent/kafkarest/resources/AsyncResponses.java:91

• The logger is using AsyncResponse.class instead of AsyncResponses.class, which may lead to confusion when identifying log entries. Consider updating the logger instantiation to use AsyncResponses.class.

private static final Logger log = LogManager.getLogger(AsyncResponse.class);

[trnguyencflt]

[minor] the title should be migrate from reload4j (log4j1) to log4j2

[shubh-ranade]

reload4j dependency is not included anymore

❯ mvn dependency:tree -Dincludes=org.slf4j
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Detecting the operating system and CPU architecture
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] kafka-rest-parent                                                  [pom]
[INFO] kafka-rest                                                         [jar]
[INFO]
[INFO] -------------------< io.confluent:kafka-rest-parent >-------------------
[INFO] Building kafka-rest-parent 8.0.0-0                                 [1/2]
[INFO]   from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:tree (default-cli) @ kafka-rest-parent ---
[INFO] io.confluent:kafka-rest-parent:pom:8.0.0-0
[INFO] \- io.confluent:common-utils:jar:8.0.0-1302:compile
[INFO]    \- org.slf4j:slf4j-api:jar:1.7.36:compile
[INFO]
[INFO] ----------------------< io.confluent:kafka-rest >-----------------------
[INFO] Building kafka-rest 8.0.0-0                                        [2/2]
[INFO]   from kafka-rest/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:tree (default-cli) @ kafka-rest ---
[INFO] io.confluent:kafka-rest:jar:8.0.0-0
[INFO] \- org.apache.kafka:kafka-clients:jar:8.0.0-370-ccs:compile
[INFO]    \- org.slf4j:slf4j-api:jar:1.7.36:compile
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for kafka-rest-parent 8.0.0-0:
[INFO]
[INFO] kafka-rest-parent .................................. SUCCESS [  0.421 s]
[INFO] kafka-rest ......................................... SUCCESS [  6.851 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.650 s
[INFO] Finished at: 2025-04-02T20:26:35+05:30
[INFO] ------------------------------------------------------------------------

❯ mvn dependency:build-classpath -DincludeArtifactIds=slf4j-reload4j
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Detecting the operating system and CPU architecture
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] kafka-rest-parent                                                  [pom]
[INFO] kafka-rest                                                         [jar]
[INFO]
[INFO] -------------------< io.confluent:kafka-rest-parent >-------------------
[INFO] Building kafka-rest-parent 8.0.0-0                                 [1/2]
[INFO]   from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:build-classpath (default-cli) @ kafka-rest-parent ---
[INFO] No dependencies found.
[INFO] Dependencies classpath:

[INFO]
[INFO] ----------------------< io.confluent:kafka-rest >-----------------------
[INFO] Building kafka-rest 8.0.0-0                                        [2/2]
[INFO]   from kafka-rest/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- dependency:3.3.0:build-classpath (default-cli) @ kafka-rest ---
[INFO] No dependencies found.
[INFO] Dependencies classpath:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for kafka-rest-parent 8.0.0-0:
[INFO]
[INFO] kafka-rest-parent .................................. SUCCESS [  0.420 s]
[INFO] kafka-rest ......................................... SUCCESS [  7.171 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  7.974 s
[INFO] Finished at: 2025-04-02T20:27:56+05:30
[INFO] ------------------------------------------------------------------------

[xuliang2019]

LGTM