Skip to content

build.sh: freeze rpm-ostree on 2025.10-2.fc42 #4326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlebon merged 1 commit into from
Sep 19, 2025
Merged

build.sh: freeze rpm-ostree on 2025.10-2.fc42 #4326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ install_rpms() {
local builddeps
local frozendeps=""

# Freeze rpm-ostree on v2025.10 until we have new enough libselinux. See
# https://github.com/coreos/fedora-coreos-tracker/issues/2030.
frozendeps=$(echo rpm-ostree-{,libs-}2025.10-2.fc42)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While using echo with command substitution to capture the output of brace expansion works here, it's not the most robust pattern in shell scripting. The behavior of echo can be inconsistent across different shells, and it can misinterpret strings that start with a hyphen as options. A safer and more idiomatic approach in bash is to use an array to hold the list of packages, and then join them into a string.

Suggested change
frozendeps=$(echo rpm-ostree-{,libs-}2025.10-2.fc42)
local temp_pkgs=(rpm-ostree-{,libs-}2025.10-2.fc42)
frozendeps="${temp_pkgs[*]}"


# First, a general update; this is best practice. We also hit an issue recently
# where qemu implicitly depended on an updated libusbx but didn't have a versioned
# requires https://bugzilla.redhat.com/show_bug.cgi?id=1625641
Expand Down
Loading