Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates Russian localization and a few role labels across multiple files, replacing occurrences of "chemist" (химик) with "pharmacist" (фармацевт) and adding two supervisor locale entries, without altering code logic or method signatures. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Resources/Locale/ru-RU/ss14-ru/prototypes/entities/objects/devices/pda.ftl`:
- Around line 74-77: The rename marker block indicates a chemist→pharmacist
rename was intended but the string ent-ChemistryPDA and its .desc still use "КПК
химика" and should be updated to the new term; update the value of
ent-ChemistryPDA and optionally its .desc to use the pharmacist-localized term
(consistent with other renamed keys), ensuring you edit the ent-ChemistryPDA
entry and its .desc so the displayed text matches the rename marker.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (23)
Resources/Locale/ru-RU/job/job-names.ftlResources/Locale/ru-RU/job/job-supervisors.ftlResources/Locale/ru-RU/preferences/loadout-groups.ftlResources/Locale/ru-RU/smartfridge/smartfridge.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/clothing/back/backpacks.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/clothing/back/duffel.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/clothing/back/satchel.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/clothing/head/hats.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/clothing/head/hoods.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/clothing/outerclothing/wintercoats.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/clothing/uniforms/jumpskirts.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/clothing/uniforms/jumpsuits.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/markers/spawners/jobs.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/mobs/player/shuttleroles/roles.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/mobs/player/shuttleroles/spawners.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/objects/devices/pda.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/objects/fun/figurines.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/objects/fun/plushielizard_jobs.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/objects/misc/identification_cards.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/structures/storage/closets/lockers/lockers.ftlResources/Locale/ru-RU/ss14-ru/prototypes/entities/structures/storage/closets/wardrobe.ftlResources/Prototypes/Roles/Jobs/Medical/medical_intern.ymlResources/Prototypes/Roles/Jobs/Science/scientist.yml
Comment on lines
+74
to
+77
| # WL-Changes: Rename start | ||
| ent-ChemistryPDA = КПК химика | ||
| .desc = На нём есть несколько обесцвеченных пятен. | ||
| # WL-Changes: Rename end |
Contributor
There was a problem hiding this comment.
Rename marker added, but the Chemistry PDA text was not actually renamed.
Line 75 still says КПК химика, so this segment remains inconsistent with the chemist → pharmacist rename done elsewhere.
💡 Proposed fix
- ent-ChemistryPDA = КПК химика
+ ent-ChemistryPDA = КПК фармацевта📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| # WL-Changes: Rename start | |
| ent-ChemistryPDA = КПК химика | |
| .desc = На нём есть несколько обесцвеченных пятен. | |
| # WL-Changes: Rename end | |
| # WL-Changes: Rename start | |
| ent-ChemistryPDA = КПК фармацевта | |
| .desc = На нём есть несколько обесцвеченных пятен. | |
| # WL-Changes: Rename end |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Resources/Locale/ru-RU/ss14-ru/prototypes/entities/objects/devices/pda.ftl`
around lines 74 - 77, The rename marker block indicates a chemist→pharmacist
rename was intended but the string ent-ChemistryPDA and its .desc still use "КПК
химика" and should be updated to the new term; update the value of
ent-ChemistryPDA and optionally its .desc to use the pharmacist-localized term
(consistent with other renamed keys), ensuring you edit the ent-ChemistryPDA
entry and its .desc so the displayed text matches the rename marker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание PR
Переименованы роли
Требования
Согласие с условиями
Критические изменения
Список изменений
🆑
Summary by CodeRabbit