🪲 Fix bug with atmosphere problems on one eye.#421
Merged
JonasGilg merged 2 commits intocosmoscout:mainfrom Mar 4, 2026
Merged
🪲 Fix bug with atmosphere problems on one eye.#421JonasGilg merged 2 commits intocosmoscout:mainfrom
JonasGilg merged 2 commits intocosmoscout:mainfrom
Conversation
Pull Request Test Coverage Report for Build 21632559816Details
💛 - Coveralls |
Member
|
Seems to be an easy fix. Have you tried it with a stereo display? The build error on Windows seems to be unrelated. I think the download link to CEF broke. |
Member
|
The build error for the pipeline is fixed, please merge the latest changes from main. |
JonasGilg
approved these changes
Mar 4, 2026
Member
JonasGilg
left a comment
JonasGilg
left a comment
There was a problem hiding this comment.
Looks good! Thak you very much.
Benman2785
added a commit
to Benman2785/cosmoscout-vr
that referenced
this pull request
Mar 19, 2026
cosmoscout#421 cosmoscout/cosmoscout-vr
Benman2785
added a commit
to Benman2785/cosmoscout-vr
that referenced
this pull request
Mar 19, 2026
cosmoscout#421 cosmoscout/cosmoscout-vr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug from issue #420 with atmosphere not rendering properly on one eye. This happened after #407 introduced the bug. The reason is that before #407 the depth and color buffers were copied on each Do(). Since #407 the copying through "mDirty = true" does not have the wished for effect. Now the "forceCopy" parameter is set to true and used to ensure copying properly.