Skip to content

Improve use of asset validation errors#2719

Open
jjnesbitt wants to merge 13 commits intomasterfrom
zarr-asset-validation-error
Open

Improve use of asset validation errors#2719
jjnesbitt wants to merge 13 commits intomasterfrom
zarr-asset-validation-error

Conversation

@jjnesbitt
Copy link
Member

Closes #2540
Closes #1653
Closes #1214

The primary purpose of this PR is to address an issue with asset validation errors for zarr assets. The existing behavior is to share the same status between assets that are in the process of validation, and zarr assets that cannot be validated yet (due to the underlying zarr not being finalized).

This is observed mostly on dandiset 000108, however other dandisets have experienced this as well. This change won't actually address the underlying problem, as the solution to that is simply to finalize the zarrs backing those assets (something I will address separately). However, it will fix the asset validation error that is shown, to more accurately describe the problem.

There are several secondary improvements:

  • Remove the deprecated VALIDATING status on the Asset model
  • Fix the broken asset validation UI
  • Separate out asset validation errors into their own endpoint, removing them from the version info endpoint.
  • Enabled by the above improvement, remove the truncation of asset validation errors (originally introduced in Truncate asset validation errors/fix memory usage #2548)

@jjnesbitt jjnesbitt added patch Increment the patch version when merged release Create a release when this pr is merged labels Feb 26, 2026
@jjnesbitt jjnesbitt force-pushed the zarr-asset-validation-error branch 2 times, most recently from fa4467e to 7ee65b2 Compare February 26, 2026 23:13
@jjnesbitt
Copy link
Member Author

I still need to address CLI integration...

@jjnesbitt jjnesbitt force-pushed the zarr-asset-validation-error branch from 7ee65b2 to 112b08c Compare March 2, 2026 23:12
@jjnesbitt jjnesbitt force-pushed the zarr-asset-validation-error branch from 112b08c to 96562a3 Compare March 2, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged release Create a release when this pr is merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

problem rendering many asset validation errors Remove use of Asset VALIDATING status if not used Dandiset info endpoint large response sizes

2 participants