Conversation
Change-Id: Id98bf0be3836a4b6245d5dea1b8fad0a60ce299a
Change-Id: I4cc693925f2c04903cc406a37a8d296f7e50b4ce
Change-Id: I059782f3859bfcec9a4b1b101cf5d24bb8ac34cb
Change-Id: I89fcb31f47c55b0ffe8cd446835d0b2fd3de3c41
Change-Id: I993c3301c42693d1314356f72f6177ba095da60e
Change-Id: Iafeebbc145b99e884775a9ad00228500bf7f574e
powerjg
reviewed
May 6, 2022
| } | ||
|
|
||
| doBurstAccess(mem_pkt); | ||
| DPRINTF(MemCtrl, |
Change-Id: I5e0a74f55a9ad06cc2713da6e80fac37b39c872f
Change-Id: I6116bfe92e6b0af5c6a4fe87bd948d85a0aa235b
Change-Id: I618baee0c502998b6e229f95b2b3f41e6f6aaa4c
Change-Id: If7a555b1d7e1eba6660a8f78e5c657a2a35b1be1
Change-Id: I2048a051940354097b2817fba471fd0225bf5b62
Change-Id: I73396619b3942582eb36a3a69574452fea33b2f6
Change-Id: I66cd87b0eb295e0bafc7d1b7188150b4731c789a
powerjg
reviewed
May 11, 2022
Member
powerjg
left a comment
powerjg
left a comment
There was a problem hiding this comment.
Only small things.
I do think we should use the other names, though :/. Sorry for the extra work!
Comment on lines
+387
to
+388
| typedef MemInterfaceParams Params; | ||
| MemInterface(const Params &_p); |
Member
There was a problem hiding this comment.
nit: This moved between the old file and this file
Change-Id: Ibaf904e5f7a570c9db7aac60ba5c419b97d05445
Change-Id: I8a2d1c49e38c53abb9741398c44700fab6f7ad77
Change-Id: Ic64bdd36fcd46a36fd34df730f4b48ad93d833de
Change-Id: Ia5ab1b2c6b9f5aeabea3b8d60866b94b82186103
Change-Id: I1b3f545efb6b1b0569fed2fa91d6a10233b7a9ce
Change-Id: I4a52067a01264fbaa62b4c4fde6f6896ae101e64
Change-Id: Ia868317e1c8809b1d5d6701dd4b9cd9c9847aef1
Contributor
Author
Member
|
Looks good! I think that the rename is all that's left now :). Thanks for the quick update. |
Change-Id: I4cceb4d35c24265037b42f3b77926082351c000f
Change-Id: I04954ce0c4a7a0fab53b73dea0e341fd7dcee2a0
Change-Id: I8efeab10527d9fdd635a30d15a2886b6c009e0a9
Change-Id: I5203c7c45edaa5ce2bc8f7d62cea8abe28605696
Change-Id: I8133281ffb2fe40ca082af3a4045ed62ce4c9222
Change-Id: I28be8bbe4e011adb2235eeba5abee424a8a037c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Add more description into commit messages
Some commits probably can be decomposed further.
HBMCtrl PR: #22