Make modules.pytz.timezone compatible with dbt-core

[tlm365]

Resolves #143.

Blocked until this PR is merged and released: chronotope/chrono-tz#202

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tai Le Manh.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[jtcohen6]

@tlm365 Thanks for another contribution! Since your first PR, I enabled a CLA check on this repo - could you give this a read and sign it? If you have signed, it might be an issue with how your email is configured for signing git commits

[tlm365]

@tlm365 Thanks for another contribution! Since your first PR, I enabled a CLA check on this repo - could you give this a read and sign it? If you have signed, it might be an issue with how your email is configured for signing git commits

@jtcohen6 Thanks for reviewing! I've signed it.

[wolfram-s]

Great. Thanks for making time zone conversion less strict and thus less annoying.

[TIHan]

Changes have been merged internally. Thank you @tlm365 !

[TIHan]

@tlm365 - Re-opening.
We had to revert the change unfortunately due to the uncased crate not being referenced correctly in the chrono-tz crate. We were not able to build dbt-fusion successfully on its own. Not your fault, and this is a change that we want.

Are you able to build dbt-fusion with these changes you have proposed? We are also currently working on getting CI working for dbt-fusion.

[tlm365]

@tlm365 - Re-opening. We had to revert the change unfortunately due to the uncased crate not being referenced correctly in the chrono-tz crate. We were not able to build dbt-fusion successfully on its own. Not your fault, and this is a change that we want.

Are you able to build dbt-fusion with these changes you have proposed? We are also currently working on getting CI working for dbt-fusion.

Oh, my apologies 🙏 I just verified via unit tests and didn’t check the full project build.

I’ve raised a PR to address the issue in chrono-tz, but it seems we’ll need to wait for the next release if we want to keep the current implementation. Otherwise, we may need to explore an alternative approach.

I’ll continue tracking this. Really appreciate you reviewing and report it to me @TIHan!

[TIHan]

I’ve raised a PR to address the issue in chrono-tz, but it seems we’ll need to wait for the next release if we want to keep the current implementation. Otherwise, we may need to explore an alternative approach.

Oh, thank you very much for reaching out to them regarding the issue; that helps us a lot.

I’ll continue tracking this. Really appreciate you reviewing and report it to me @TIHan!

Of course! We love the change and we did our best to figure it out internally but it's ultimately up to chrono-tz.

[TIHan]

Oh, my apologies 🙏 I just verified via unit tests and didn’t check the full project build.

Also, no worries. It's mainly our fault. We need to have CI running build + tests on the public repo, but it's taking some time to get that set up.

[dbeatty10]

@tlm365 chronotope/chrono-tz#202 was closed by the maintainer of chrono-tz.

Do you see any path forward for this PR?

[tlm365]

@tlm365 chronotope/chrono-tz#202 was closed by the maintainer of chrono-tz.

Do you see any path forward for this PR?

@dbeatty10 Thanks for reviewing.
Somehow, I have successfully built the project after merging the latest code from main. This PR now works fine and builds successfully on my machine (MacOS-ARM).

Dismissing per #145 (comment)

[TIHan]

@tlm365 I'm still working through this internally :) - I still had some issues with building - nothing on your end you can do.