Use palantir-java-format 2.57.0 on Java 21#2447
Merged
Goooler merged 4 commits intodiffplug:mainfrom Mar 14, 2025
Merged
Conversation
improved code formatting for Java 21 ref: palantir/palantir-java-format#952
Goooler
approved these changes
Mar 14, 2025
Member
|
Published in |
Contributor
|
This has been causing problems in Jenkins plugins using the default configuration because certain maven-compiler-plugin), without reference to the version of Java which happens to be running the tool.
|
6 tasks
slawekjaranowski
added a commit
to mojohaus/mojo-parent
that referenced
this pull request
Jun 12, 2025
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used. It causes a different code format depends on using JDK references: - diffplug/spotless#2447 - diffplug/spotless#2503 - palantir/palantir-java-format#1320 Additionally, we can't use older spotless on JDK8
slawekjaranowski
added a commit
to slawekjaranowski/maven-parent
that referenced
this pull request
Jun 12, 2025
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used. It causes a different code format depends on using JDK references: - diffplug/spotless#2447 - diffplug/spotless#2503 - palantir/palantir-java-format#1320 As issue - diffplug/spotless#2503 was closed, reverting spotless plugin to an older version is not a resolution.
slawekjaranowski
added a commit
to slawekjaranowski/maven-parent
that referenced
this pull request
Jun 13, 2025
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used. It causes a different code format depends on using JDK references: - diffplug/spotless#2447 - diffplug/spotless#2503 - palantir/palantir-java-format#1320 As issue - diffplug/spotless#2503 was closed, reverting spotless plugin to an older version is not a resolution.
slawekjaranowski
added a commit
to apache/maven-parent
that referenced
this pull request
Jun 13, 2025
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used. It causes a different code format depends on using JDK references: - diffplug/spotless#2447 - diffplug/spotless#2503 - palantir/palantir-java-format#1320 As issue - diffplug/spotless#2503 was closed, reverting spotless plugin to an older version is not a resolution.
slawekjaranowski
added a commit
to mojohaus/mojo-parent
that referenced
this pull request
Jun 13, 2025
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used. It causes a different code format depends on using JDK references: - diffplug/spotless#2447 - diffplug/spotless#2503 - palantir/palantir-java-format#1320 Additionally, we can't use older spotless on JDK8
slawekjaranowski
added a commit
to mojohaus/mojo-parent
that referenced
this pull request
Jun 13, 2025
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used. It causes a different code format depends on using JDK references: - diffplug/spotless#2447 - diffplug/spotless#2503 - palantir/palantir-java-format#1320 Additionally, we can't use older spotless on JDK8
slawekjaranowski
added a commit
to mojohaus/mojo-parent
that referenced
this pull request
Jun 13, 2025
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used. It causes a different code format depends on using JDK references: - diffplug/spotless#2447 - diffplug/spotless#2503 - palantir/palantir-java-format#1320 Additionally, we can't use older spotless on JDK8
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Palantir Java formatter to version
2.57.0for improved code formatting for Java 21ref: palantir/palantir-java-format#952 and palantir/palantir-java-format#1211