data: Fix signet of spite alternative power interaction... maybe?#993
Draft
marcustyphoon wants to merge 2 commits intomainfrom
Draft
data: Fix signet of spite alternative power interaction... maybe?#993marcustyphoon wants to merge 2 commits intomainfrom
marcustyphoon wants to merge 2 commits intomainfrom
Conversation
marcustyphoon
force-pushed
the
signet-of-spite-alternative-power
branch
from
70d797a to
60d3d37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of a mess; I have to think about this. This would make "soul shards/nightmare weapon/painful bond in shroud" wrong, for one.
Naively adopting the current scenarios system for shroud instead of doing this probably doesn't fix this either. Making signet of spite have
advancedUptimeSimulation: { correlation: { category: shroud, group: false } } }is great because it would apply the signet power to only some of the soul shards, but bad because it would force signet of spite uptime to be entered as 100 - shroud uptime, i.e. it wouldn't let you simulate casting the signet. Condi harbinger does.Truthfully, it's probably easiest to ignore the small amount of time the signet is uncast in that case (if a condi build took it, they probably cast it close to off cooldown; if a power build took it, they probably don't cast it) and just implement "signet of spite is always applied out of shroud and never applied in shroud." This would still make "soul shards/nightmare weapon/painful bond in shroud" wrong. Eugh.