Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates translation locale files for djangocms_versioning across multiple languages and introduces a dedicated Simplified Chinese (zh_CN) locale file. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Please double-check whether both
zh_Hansandzh_CNlocales are needed and consistent with the project's existing locale conventions to avoid maintaining duplicate or conflicting Chinese translations.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Please double-check whether both `zh_Hans` and `zh_CN` locales are needed and consistent with the project's existing locale conventions to avoid maintaining duplicate or conflicting Chinese translations.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
==========================================
+ Coverage 90.55% 93.80% +3.24%
==========================================
Files 72 76 +4
Lines 2732 2744 +12
Branches 322 0 -322
==========================================
+ Hits 2474 2574 +100
+ Misses 182 170 -12
+ Partials 76 0 -76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.
Summary by Sourcery
Update and expand translation resources for djangocms_versioning.
Enhancements: