Skip to content

Conversation

@jycor
Copy link
Contributor

@jycor jycor commented Apr 9, 2025

This PR implements STD() and VARIANCE() and its aliases.

docs: https://dev.mysql.com/doc/refman/8.4/en/aggregate-functions.html#function_std
syntax: dolthub/vitess#409
fixes: dolthub/dolt#9088

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One main comment for deduplicating code. I said maybe add framer tests lat night, but it seems like that's less relevant than i originally imagined. Are there any specific types that could behave strangely? Rounding/decimal inconsistencies

@jycor jycor changed the title implement std(), stddev(), and stddev_pop() implement stddev_pop(), stddev_samp(), var_pop(), var_samp(), and aliases Apr 10, 2025
@jycor jycor merged commit 5632d67 into main Apr 10, 2025
8 checks passed
@jycor jycor deleted the james/std branch April 10, 2025 18:20
samjewell added a commit to grafana/grafana that referenced this pull request Apr 11, 2025
Bump Go MySQL Server to the latest version, to get support for STDDEV()
and VARIANCE() functions, and their aliases.

See dolthub/go-mysql-server#2928
samjewell added a commit to grafana/grafana that referenced this pull request Apr 15, 2025
* SQL Expressions: Bump GMS for STDDEV(), VARIANCE()

Bump Go MySQL Server to the latest version, to get support for STDDEV()
and VARIANCE() functions, and their aliases.

See dolthub/go-mysql-server#2928

* Update app-code to comply with latest GMS version

* Run `go mod tidy`

* Update test which had depended on STDDEV being missing

* Run `make update-workspace`
samjewell added a commit to samjewell/docs that referenced this pull request Apr 15, 2025
jycor pushed a commit to samjewell/docs that referenced this pull request Apr 15, 2025
jycor pushed a commit to samjewell/docs that referenced this pull request Apr 15, 2025
jycor pushed a commit to dolthub/docs that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request for STDEV_POP() (and aliases) and VAR_POP() (and alias)

3 participants