-
-
Notifications
You must be signed in to change notification settings - Fork 238
implement stddev_pop(), stddev_samp(), var_pop(), var_samp(), and aliases
#2928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
approved these changes
Apr 10, 2025
Contributor
max-hoffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One main comment for deduplicating code. I said maybe add framer tests lat night, but it seems like that's less relevant than i originally imagined. Are there any specific types that could behave strangely? Rounding/decimal inconsistencies
std(), stddev(), and stddev_pop()stddev_pop(), stddev_samp(), var_pop(), var_samp(), and aliases
samjewell
added a commit
to grafana/grafana
that referenced
this pull request
Apr 11, 2025
Bump Go MySQL Server to the latest version, to get support for STDDEV() and VARIANCE() functions, and their aliases. See dolthub/go-mysql-server#2928
3 tasks
samjewell
added a commit
to grafana/grafana
that referenced
this pull request
Apr 15, 2025
* SQL Expressions: Bump GMS for STDDEV(), VARIANCE() Bump Go MySQL Server to the latest version, to get support for STDDEV() and VARIANCE() functions, and their aliases. See dolthub/go-mysql-server#2928 * Update app-code to comply with latest GMS version * Run `go mod tidy` * Update test which had depended on STDDEV being missing * Run `make update-workspace`
samjewell
added a commit
to samjewell/docs
that referenced
this pull request
Apr 15, 2025
These functions were added in these PRs: - dolthub/go-mysql-server#2928 - dolthub/go-mysql-server#2935 - dolthub/vitess#410
jycor
pushed a commit
to samjewell/docs
that referenced
this pull request
Apr 15, 2025
These functions were added in these PRs: - dolthub/go-mysql-server#2928 - dolthub/go-mysql-server#2935 - dolthub/vitess#410
jycor
pushed a commit
to samjewell/docs
that referenced
this pull request
Apr 15, 2025
These functions were added in these PRs: - dolthub/go-mysql-server#2928 - dolthub/go-mysql-server#2935 - dolthub/vitess#410
jycor
pushed a commit
to dolthub/docs
that referenced
this pull request
Apr 15, 2025
These functions were added in these PRs: - dolthub/go-mysql-server#2928 - dolthub/go-mysql-server#2935 - dolthub/vitess#410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
STD()andVARIANCE()and its aliases.docs: https://dev.mysql.com/doc/refman/8.4/en/aggregate-functions.html#function_std
syntax: dolthub/vitess#409
fixes: dolthub/dolt#9088