Skip to content

Add support for subscriptions that use DeserializeSeed#1

Draft
phil-opp wants to merge 7 commits intomainfrom
deserialize-seed
Draft

Add support for subscriptions that use DeserializeSeed#1
phil-opp wants to merge 7 commits intomainfrom
deserialize-seed

Conversation

@phil-opp
Copy link

@phil-opp phil-opp commented Jul 21, 2023

Some types need additional context for deserialization, which makes it impossible to implement DeserializeOwned. Instead, deserialization happens through the DeserializeSeed trait.

This PR adds support for creating subscriptions that use DeserializeSeed. The two main API changes are:

  • Don't require the DeserializeOwned bound to create subscriptions. Instead, require them only for the methods that absolutely need it (such as take).
  • Add a new take_seed method that deserializes using DeserializeSeed.

These changes depend on two other PRs. We might want to upstream it once they are merged:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant