[23979] Fix GAP messages are not sent when there is no Reader requesting the DATA by richiware · Pull Request #6181 · eProsima/Fast-DDS

richiware · 2025-11-19T11:51:49Z

Description

When Content Filter is being performed on the writer side, and samples are always irrelevant for all readers, currently a heartbeat period is received without notification of the previous GAP sequence of samples, and the readers annotate those samples as lost. This PR fixes this, ensuring that a GAP message is sent before the HEARTBEAT period or before a DATA for one of the readers.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

src/cpp/rtps/writer/ReaderProxy.cpp

src/cpp/rtps/writer/ReaderProxy.hpp

test/blackbox/common/DDSBlackboxTestsContentFilter.cpp

src/cpp/rtps/writer/ReaderProxy.cpp

mergify · 2025-11-21T20:54:06Z

🧪 CI Insights

Here's what we observed from your CI run for de998bc.

❌ Job Failures

Pipeline	Job	Retries	🔍 CI Insights	📄 Logs
`Fast DDS MacOS CI`	`mac-ci / fastdds_test ()`	`0`	View	View
`Fast DDS Ubuntu CI`	`ubuntu-ci / fastdds_test (RelWithDebInfo)`	`0`	View	View
`Fast DDS Windows CI`	`windows-ci / fastdds_test (RelWithDebInfo, examples), v142`	`0`	View	View
`Fast DDS Windows CI`	`windows-ci / fastdds_test (RelWithDebInfo, examples), v143`	`0`	View	View

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

MiguelCompany · 2025-11-26T16:07:20Z

@Mergifyio backport 3.3.x 3.2.x 2.14.x

mergify · 2025-11-26T16:07:32Z

backport 3.3.x 3.2.x 2.14.x

✅ Backports have been created

Details

#6196 Fix GAP messages are not sent when there is no Reader requesting the DATA (backport #6181) has been created for branch 3.3.x
#6197 Fix GAP messages are not sent when there is no Reader requesting the DATA (backport #6181) has been created for branch 3.2.x but encountered conflicts
#6198 Fix GAP messages are not sent when there is no Reader requesting the DATA (backport #6181) has been created for branch 2.14.x but encountered conflicts

…DATA (#6181) * Refs #23919. Tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix cornercase Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix jobs needs log Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 062258c)

…DATA (#6181) * Refs #23919. Tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix cornercase Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix jobs needs log Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 062258c) # Conflicts: # test/blackbox/common/DDSBlackboxTestsContentFilter.cpp

…DATA (#6181) * Refs #23919. Tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix cornercase Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix jobs needs log Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 062258c) # Conflicts: # examples/cpp/content_filter/SubscriberApp.hpp # src/cpp/rtps/writer/StatefulWriter.cpp # test/blackbox/common/DDSBlackboxTestsContentFilter.cpp # test/dds/xtypes/TypeLookupServiceSubscriber.cpp

…DATA (#6181) * Refs #23919. Tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix cornercase Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix jobs needs log Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

…DATA (#6181) * Refs #23919. Tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix cornercase Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix jobs needs log Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 062258c)

…DATA (#6181) (#6198) * Refs #23919. Tests * Refs #23919. Fix * Refs #23919. Fix cornercase * Refs #23919. Apply suggestions * Refs #23919. Fix jobs needs log * Refs #23919. Apply suggestions --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González <ricardo@richiware.dev>

…DATA (#6181) (#6196) * Refs #23919. Tests * Refs #23919. Fix * Refs #23919. Fix cornercase * Refs #23919. Apply suggestions * Refs #23919. Fix jobs needs log * Refs #23919. Apply suggestions --------- (cherry picked from commit 062258c) Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González <ricardo@richiware.dev>

…DATA (#6181) * Refs #23919. Tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix cornercase Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix jobs needs log Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 062258c) # Conflicts: # test/blackbox/common/DDSBlackboxTestsContentFilter.cpp

…DATA (#6181) (#6197) * Fix GAP messages are not sent when there is no Reader requesting the DATA (#6181) * Refs #23919. Tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix cornercase Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix jobs needs log Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 062258c) # Conflicts: # test/blackbox/common/DDSBlackboxTestsContentFilter.cpp * Reset irrelevant sequence numbers interval in proxy readers (#6241) * Refs #24038. Regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply new uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González <ricardo@richiware.dev>

richiware force-pushed the bugfix/23919 branch from c56b6d0 to 9bcdb4b Compare November 20, 2025 13:44

richiware requested a review from MiguelCompany November 21, 2025 07:21

github-actions bot added the ci-pending PR which CI is running label Nov 21, 2025

MiguelCompany added this to the v3.4.2 milestone Nov 21, 2025

MiguelCompany requested changes Nov 21, 2025

View reviewed changes

src/cpp/rtps/writer/ReaderProxy.cpp Outdated Show resolved Hide resolved

richiware force-pushed the bugfix/23919 branch from 54c1634 to 79ccbe0 Compare November 21, 2025 12:13

MiguelCompany approved these changes Nov 21, 2025

View reviewed changes

MiguelCompany self-requested a review November 21, 2025 12:16

MiguelCompany previously approved these changes Nov 21, 2025

View reviewed changes

richiware dismissed MiguelCompany’s stale review via 74f6411 November 24, 2025 08:10

richiware requested a review from MiguelCompany November 24, 2025 08:11

richiware force-pushed the bugfix/23919 branch from 74f6411 to 4a5f182 Compare November 24, 2025 08:13

richiware requested review from MiguelCompany and removed request for MiguelCompany November 24, 2025 08:13

richiware force-pushed the bugfix/23919 branch from 4a5f182 to d8bf3ce Compare November 24, 2025 08:30

richiware requested review from MiguelCompany and removed request for MiguelCompany November 24, 2025 08:31

richiware force-pushed the bugfix/23919 branch from d8bf3ce to e3698df Compare November 24, 2025 08:37

richiware requested review from MiguelCompany and removed request for MiguelCompany November 24, 2025 08:37

richiware force-pushed the bugfix/23919 branch from e3698df to f859cb8 Compare November 24, 2025 08:46

richiware requested review from MiguelCompany and removed request for MiguelCompany November 24, 2025 08:46

richiware force-pushed the bugfix/23919 branch from f859cb8 to 79ccbe0 Compare November 24, 2025 09:38

richiware requested review from MiguelCompany and removed request for MiguelCompany November 25, 2025 06:31

richiware requested a review from MiguelCompany November 26, 2025 08:00

MiguelCompany approved these changes Nov 26, 2025

View reviewed changes

richiware requested a review from MiguelCompany November 26, 2025 09:58

Refs #23919. Apply suggestions

de998bc

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware force-pushed the bugfix/23919 branch from ddd1016 to de998bc Compare November 26, 2025 09:59

richiware requested review from MiguelCompany and removed request for MiguelCompany November 26, 2025 10:14

MiguelCompany approved these changes Nov 26, 2025

View reviewed changes

MiguelCompany added first-to-merge ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Nov 26, 2025

MiguelCompany merged commit 062258c into master Nov 26, 2025
24 of 28 checks passed

MiguelCompany deleted the bugfix/23919 branch November 26, 2025 16:06

This was referenced Nov 26, 2025

Fix GAP messages are not sent when there is no Reader requesting the DATA (backport #6181) #6196

Merged

Fix GAP messages are not sent when there is no Reader requesting the DATA (backport #6181) #6197

Merged

mergify bot mentioned this pull request Nov 26, 2025

Fix GAP messages are not sent when there is no Reader requesting the DATA (backport #6181) #6198

Merged

12 tasks

richiware changed the title ~~Fix GAP messages are not sent when there is no Reader requesting the DATA~~ [23979] Fix GAP messages are not sent when there is no Reader requesting the DATA Nov 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[23979] Fix GAP messages are not sent when there is no Reader requesting the DATA#6181

[23979] Fix GAP messages are not sent when there is no Reader requesting the DATA#6181
MiguelCompany merged 6 commits intomasterfrom
bugfix/23919

richiware commented Nov 19, 2025 •

edited by MiguelCompany

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Nov 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

MiguelCompany commented Nov 26, 2025

Uh oh!

mergify bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

richiware commented Nov 19, 2025 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

❌ Job Failures

Uh oh!

Uh oh!

MiguelCompany commented Nov 26, 2025

Uh oh!

mergify bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

richiware commented Nov 19, 2025 •

edited by MiguelCompany

Loading

mergify bot commented Nov 21, 2025 •

edited

Loading

mergify bot commented Nov 26, 2025 •

edited

Loading