Skip to content

Preventing "Commands" Command and cleanup #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreineckearm merged 11 commits into from
Dec 8, 2025
Merged

Preventing "Commands" Command and cleanup #472

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1ef25ff
Adding a warning to users when they try the commands command via the …
omarArm Dec 4, 2025
4c4e0a0
failing silently when commands command is sent
omarArm Dec 5, 2025
756ebd2
updating warning message to show the real cause of the issue
omarArm Dec 5, 2025
a409379
removing the double quotes from the warning message
omarArm Dec 5, 2025
3586412
removing the double quotes from the test name
omarArm Dec 5, 2025
211eb58
changing tests infrastructure to have chai globally
omarArm Dec 8, 2025
ff6dc49
making regex more robust against args and short forms
omarArm Dec 8, 2025
36fdce8
ran a yarn format
omarArm Dec 8, 2025
595e4d9
update test to match change in warning message
omarArm Dec 8, 2025
991f2f5
removing binary file that was added by mistake
omarArm Dec 8, 2025
f87833a
adding copyright message and update mocharc for windows
omarArm Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/gdb/GDBDebugSessionBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2004,14 +2004,15 @@ export abstract class GDBDebugSessionBase extends LoggingDebugSession {

if (isCliCommand) {
const expressionNoPrefix = expression.slice(1).trim();
const regexCommands = new RegExp('^\\s*(?:commands)\\s*$');
const regexDisable = new RegExp(
'^\\s*(?:dis|disa|disable)\\s*(?:(?:breakpoint|count|delete|once)\\d*)?\\s*\\d*\\s*$'
'^\\s*(?:dis|disa|disab|disabl|disable)\\s*(?:(?:breakpoint|count|delete|once)\\d*)?\\s*\\d*\\s*$'
);
const regexEnable = new RegExp(
'^\\s*(?:en|enable)\\s*(?:(?:breakpoint|count|delete|once)\\d*)?\\s*\\d*\\s*$'
'^\\s*(?:en|ena|enab|enabl|enable)\\s*(?:(?:breakpoint|count|delete|once)\\d*)?\\s*\\d*\\s*$'
);
const regexDelete = new RegExp(
'^\\s*(?:d|del|delete)\\s+(?:breakpoints\\s+)?(\\d+)?\\s*$'
'^\\s*(?:d|de|del|dele|delet|delete)\\s+(?:breakpoints\\s+)?(\\d+)?\\s*$'
);
if (
expressionNoPrefix.search(regexDisable) != -1 ||
Expand All @@ -2037,6 +2038,21 @@ export abstract class GDBDebugSessionBase extends LoggingDebugSession {
);
}
}
if (expressionNoPrefix.search(regexCommands) != -1) {
this.sendEvent(
new OutputEvent(
'warning: commands command is not supported via GDB/MI interface',
'stdout'
)
);
response.body = {
result: '',
variablesReference: 0,
};
this.sendResponse(response);
// Avoid sending the command to GDB
return;
}
return await this.evaluateRequestGdbCommand(
response,
expressionNoPrefix,
Expand Down
16 changes: 16 additions & 0 deletions src/integration-tests/evaluate.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ import {
standardBeforeEach,
testProgramsDir,
} from './utils';
import * as chai from 'chai';
import * as chaistring from 'chai-string';
chai.use(chaistring);

describe('evaluate request', function () {
let dc: CdtDebugClient;
Expand Down Expand Up @@ -97,6 +100,19 @@ describe('evaluate request', function () {
await event;
});

it('should send a warning when the commands command is sent', async function () {
const event = dc.waitForOutputEvent(
'stdout',
'warning: commands command is not supported via GDB/MI interface'
);
await dc.evaluateRequest({
context: 'repl',
expression: '> commands',
frameId: scope.frame.id,
});
await event;
});

it('should send a warning when evaluating a delete instruction breakpoint command is sent', async function () {
// set instruction breakpoint
await dc.setInstructionBreakpointsRequest({
Expand Down