Enable "deprecation" compiler warnings #778
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We currently ignore quite a lot of deprecation warnings. Like a lot of the BigDecimal methods in PrecisionGeometry. |
|
Given that those are plenty of new warnings, I'll split this up into smaller PRs, each focusing on a single component. |
ptziegler
force-pushed
the
_deprecation-warnings
branch
from
5a356cc to
fcb3ad5
Compare
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Sep 6, 2025
Those field has been marked as deprecated since forever and is only referenced within the same package and can therefore be made package-private (or private) in a future release. The "removal" warning needs to be suppressed, wherever this field is referenced. Contributes to eclipse-gef#778
This was referenced Sep 6, 2025
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Sep 6, 2025
The setScale(...) method accepting the mode as integer has been deprecated with Java 9. Given that Draw2D requires at least Java 17, we can simply use the drop-in replacement via the RoundingMode enum. Contributes to eclipse-gef#778
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Sep 6, 2025
The setScale(...) method accepting the mode as integer has been deprecated with Java 9. Given that Draw2D requires at least Java 17, we can simply use the drop-in replacement via the RoundingMode enum. Contributes to eclipse-gef#778
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Sep 6, 2025
The setScale(...) method accepting the mode as integer has been deprecated with Java 9. Given that Draw2D requires at least Java 17, we can simply use the drop-in replacement via the RoundingMode enum. Contributes to eclipse-gef#778
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Sep 6, 2025
The setScale(...) method accepting the mode as integer has been deprecated with Java 9. Given that Draw2D requires at least Java 17, we can simply use the drop-in replacement via the RoundingMode enum. Contributes to eclipse-gef#778
azoitl
pushed a commit
that referenced
this pull request
Sep 6, 2025
Those field has been marked as deprecated since forever and is only referenced within the same package and can therefore be made package-private (or private) in a future release. The "removal" warning needs to be suppressed, wherever this field is referenced. Contributes to #778
ptziegler
force-pushed
the
_deprecation-warnings
branch
from
fcb3ad5 to
224ade1
Compare
azoitl
pushed a commit
that referenced
this pull request
Sep 7, 2025
The setScale(...) method accepting the mode as integer has been deprecated with Java 9. Given that Draw2D requires at least Java 17, we can simply use the drop-in replacement via the RoundingMode enum. Contributes to #778
ptziegler
force-pushed
the
_deprecation-warnings
branch
from
224ade1 to
66b694a
Compare
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Sep 8, 2025
This class is package-private, but not used anywhere. Main motivation for this removal is the dependency to the deprecated ViewForm color constants. Contributes to eclipse-gef#778
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Sep 8, 2025
This was referenced Sep 8, 2025
azoitl
pushed a commit
that referenced
this pull request
Sep 8, 2025
This class is package-private, but not used anywhere. Main motivation for this removal is the dependency to the deprecated ViewForm color constants. Contributes to #778
ptziegler
force-pushed
the
_deprecation-warnings
branch
from
66b694a to
1419fba
Compare
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Sep 21, 2025
If a "FocusIn" event is fired for the RulerComposite, the contents of the RulerViewer should be focused, unless any other part has already requested focus. Rather than checking whether the deprecated field is checked, we can check whether the FOCUS flag has been set for the focused edit part. This flag is only set when setFocus(...) is called on the EditPartViewer and should therefore be set exactly when the local variable is set. Conversely, the focus should be cleared by an "FocusOut" event, unless any other part has taken the focus. Contributes to eclipse-gef#778
azoitl
pushed a commit
that referenced
this pull request
Sep 22, 2025
If a "FocusIn" event is fired for the RulerComposite, the contents of the RulerViewer should be focused, unless any other part has already requested focus. Rather than checking whether the deprecated field is checked, we can check whether the FOCUS flag has been set for the focused edit part. This flag is only set when setFocus(...) is called on the EditPartViewer and should therefore be set exactly when the local variable is set. Conversely, the focus should be cleared by an "FocusOut" event, unless any other part has taken the focus. Contributes to #778
ptziegler
force-pushed
the
_deprecation-warnings
branch
from
1419fba to
36cb52e
Compare
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Oct 3, 2025
The example editors override the deprecated commandStackChanged() method to manage the "dirty" flag of the editor. For backwards-compatibility, this method is call by the non-deprecated stackChanged method. Contributes to eclipse-gef#778
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Oct 3, 2025
The example editors override the deprecated commandStackChanged() method to manage the "dirty" flag of the editor. For backwards-compatibility, this method is call by the non-deprecated stackChanged method. Contributes to eclipse-gef#778
azoitl
pushed a commit
that referenced
this pull request
Oct 4, 2025
The example editors override the deprecated commandStackChanged() method to manage the "dirty" flag of the editor. For backwards-compatibility, this method is call by the non-deprecated stackChanged method. Contributes to #778
ptziegler
force-pushed
the
_deprecation-warnings
branch
from
36cb52e to
5fd3c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.