Skip to content

iox-#2426 Fix comparison operator in channel.inl#2427

Merged
FerdinandSpitzschnueffler merged 1 commit intoeclipse-iceoryx:mainfrom
FerdinandSpitzschnueffler:iox-2426-fix-gateway-channel
Mar 7, 2025
Merged

iox-#2426 Fix comparison operator in channel.inl#2427
FerdinandSpitzschnueffler merged 1 commit intoeclipse-iceoryx:mainfrom
FerdinandSpitzschnueffler:iox-2426-fix-gateway-channel

Conversation

@FerdinandSpitzschnueffler
Copy link
Contributor

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler commented Mar 6, 2025

Notes for Reviewer

This PR replaces the call to the non-existing getService in the comparison operator of Channel with getServiceDescription. Another option would be to remove the comparison operator completely

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (c616c3b) to head (476539f).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2427      +/-   ##
==========================================
- Coverage   78.68%   78.68%   -0.01%     
==========================================
  Files         440      440              
  Lines       16986    16988       +2     
  Branches     2361     2361              
==========================================
+ Hits        13366    13367       +1     
  Misses       2740     2740              
- Partials      880      881       +1     
Flag Coverage Δ
unittests 78.48% <100.00%> (-0.01%) ⬇️
unittests_timing 15.35% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/iceoryx_posh/internal/gateway/channel.inl 91.30% <100.00%> (+0.82%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Once #2428 is merged, you need to rebase to main to get the CI fixes

@elBoberido
Copy link
Member

@FerdinandSpitzschnueffler the branch is now merged and you can rebase

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler force-pushed the iox-2426-fix-gateway-channel branch from 547c7cf to 3726596 Compare March 6, 2025 15:00
elBoberido
elBoberido previously approved these changes Mar 6, 2025
@elBoberido
Copy link
Member

elBoberido commented Mar 6, 2025

@FerdinandSpitzschnueffler can you add the issue to the changelog ... or did you intentionally not add it?

@FerdinandSpitzschnueffler
Copy link
Contributor Author

@FerdinandSpitzschnueffler can you add the issue to the changelog ... or did you intentionally not add it?

It's just been too long since my last commit 😬

Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back to iceoryx classic :)

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler merged commit 424d3f5 into eclipse-iceoryx:main Mar 7, 2025
23 checks passed
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler deleted the iox-2426-fix-gateway-channel branch March 7, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Solves a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile error with clang 19.1.7

2 participants