iox-#2426 Fix comparison operator in channel.inl#2427
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2427 +/- ##
==========================================
- Coverage 78.68% 78.68% -0.01%
==========================================
Files 440 440
Lines 16986 16988 +2
Branches 2361 2361
==========================================
+ Hits 13366 13367 +1
Misses 2740 2740
- Partials 880 881 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
elBoberido
left a comment
There was a problem hiding this comment.
Looks good. Once #2428 is merged, you need to rebase to main to get the CI fixes
|
@FerdinandSpitzschnueffler the branch is now merged and you can rebase |
547c7cf to
3726596
Compare
|
@FerdinandSpitzschnueffler can you add the issue to the changelog ... or did you intentionally not add it? |
3726596 to
476539f
Compare
It's just been too long since my last commit 😬 |
elBoberido
left a comment
There was a problem hiding this comment.
Welcome back to iceoryx classic :)
424d3f5
into
eclipse-iceoryx:main
Notes for Reviewer
This PR replaces the call to the non-existing
getServicein the comparison operator ofChannelwithgetServiceDescription. Another option would be to remove the comparison operator completelyPre-Review Checklist for the PR Author
iox-123-this-is-a-branch)iox-#123 commit text)task-list-completed)Checklist for the PR Reviewer
iceoryx_hoofshave been added to./clang-tidy-diff-scans.txtPost-review Checklist for the PR Author
References