Support SVG icons in extension point editor#2030
Merged
HannesWell merged 1 commit intoeclipse-pde:masterfrom Oct 19, 2025
Merged
Conversation
Fixes eclipse-pde#2025 For modernization also replace array field by List field Signed-off-by: Daniel Krügler <daniel.kruegler@gmail.com>
Contributor
Author
|
@HannesWell : Unfortunately the ECA problem still persist, even though I provided now a single commit. I created a new ECA now, hope that this solves the problem. |
Contributor
Author
|
OK, creating a new ECA seemed to solved the issue. Can please someone help with the remaining Jenkins build issues? Thanks! |
HannesWell
approved these changes
Oct 19, 2025
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
OK, creating a new ECA seemed to solved the issue.
Great.
Can please someone help with the remaining Jenkins build issues?
Unfortunately we have an infrastructure issue with Jenkins at the moment, so for now this can be ignored.
Btw. the Signed-off-by footer is not necessary anymore.
This change looks good and works well.
Thank you for this contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2025
For modernization also replace array field by List field