Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

Also change JUnit 5 bundle requirements to package imports.

Required as JUnit 6 is available in target platform since

which makes GHA builds fail with "no tests found", such as in https://github.com/eclipse-platform/eclipse.platform.ui/actions/runs/18377868347/job/52356324874?pr=3387

For similar changes in PDE, compare for:

@HeikoKlare HeikoKlare force-pushed the junit5-version-constraints branch from 8baa1a2 to 6e72c2d Compare October 9, 2025 15:31
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.e4.core.commands.tests/META-INF/MANIFEST.MF
tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF
tests/org.eclipse.e4.ui.tests.css.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 5612a7b39fbd31c7d79bd6d53807bd3ad050d287 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 9 Oct 2025 15:35:48 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/tests/org.eclipse.e4.core.commands.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.e4.core.commands.tests/META-INF/MANIFEST.MF
index 7f17a4297a..19938ae9e3 100644
--- a/tests/org.eclipse.e4.core.commands.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.e4.core.commands.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.e4.core.commands.tests;singleton:=true
-Bundle-Version: 0.14.500.qualifier
+Bundle-Version: 0.14.600.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Require-Bundle: org.eclipse.core.commands,
  org.eclipse.e4.core.commands,
diff --git a/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF b/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF
index 1c2c452fde..83d8ecbfed 100644
--- a/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.e4.ui.tests.css.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.e4.ui.tests.css.core
-Bundle-Version: 1.302.600.qualifier
+Bundle-Version: 1.302.700.qualifier
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.swt,
  org.eclipse.e4.ui.css.core,
diff --git a/tests/org.eclipse.e4.ui.tests.css.swt/META-INF/MANIFEST.MF b/tests/org.eclipse.e4.ui.tests.css.swt/META-INF/MANIFEST.MF
index 160a4e07e3..7be65c62f4 100644
--- a/tests/org.eclipse.e4.ui.tests.css.swt/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.e4.ui.tests.css.swt/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.e4.ui.tests.css.swt; singleton:=true
-Bundle-Version: 0.12.800.qualifier
+Bundle-Version: 0.12.900.qualifier
 Require-Bundle: org.eclipse.e4.ui.css.core,
  org.eclipse.e4.ui.css.swt,
  org.eclipse.e4.ui.css.swt.theme;bundle-version="0.9.1",
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

HeikoKlare and others added 2 commits October 9, 2025 18:26
Also change JUnit 5 bundle requirements to package imports.
@HeikoKlare HeikoKlare force-pushed the junit5-version-constraints branch from b855356 to 6673a36 Compare October 9, 2025 16:26
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Test Results

 3 018 files  + 2 415   3 018 suites  +2 415   2h 44m 41s ⏱️ + 2h 42m 39s
 8 226 tests + 6 898   7 977 ✅ + 6 652  249 💤 +246  0 ❌ ±0 
23 598 runs  +19 566  22 804 ✅ +18 783  794 💤 +783  0 ❌ ±0 

Results for commit 6673a36. ± Comparison against base commit 2c5b605.

@HeikoKlare HeikoKlare merged commit 9a6b6ae into eclipse-platform:master Oct 9, 2025
18 checks passed
@HeikoKlare HeikoKlare deleted the junit5-version-constraints branch October 9, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants