Make read-only predicate support Resource and EAnnotation#1358
Merged
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom Jun 12, 2025
Merged
Make read-only predicate support Resource and EAnnotation#1358AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
Conversation
Member
|
#1339 has already been merged. Is it normal that you have a commit in this PR that references this issue? |
Contributor
Author
|
My bad, I was not up to date on my branch :-) |
Member
|
Tests are missing. Could you please add some? |
flatombe
force-pushed
the
dev/FLA/1357
branch
2 times, most recently
from
ebdd13f to
43d0db6
Compare
Contributor
Author
|
I've added the unit tests for the whole class, and updated the release notes so the build should succeed now. |
* SysONReadOnlyObjectPredicateDelegate now supports Resource and EAnnotation. * Add unit tests for SysONReadOnlyObjectPredicateDelegate. * Update changelog and release notes accordingly. Bug: eclipse-syson#1357 Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
AxelRICHARD
force-pushed
the
dev/FLA/1357
branch
from
43d0db6 to
f4650fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?