Skip to content

Conversation

cauemarcondes
Copy link
Contributor

Meta issue: elastic/kibana#116760
The apm_user role was marked as deprecated in 7.13 and was supposed to be removed in 8.0.
All mentions of apm_user role were finally removed in elastic/kibana#132790 and this PR removes the actual role.

@cauemarcondes cauemarcondes requested a review from a team as a code owner November 13, 2024 10:17
Copy link
Contributor

Documentation preview:

Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n1v0lg n1v0lg self-requested a review November 14, 2024 09:53
@n1v0lg n1v0lg added the test-full-bwc Trigger full BWC version matrix tests label Nov 14, 2024
@n1v0lg
Copy link
Contributor

n1v0lg commented Nov 14, 2024

@elasticmachine update branch

Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM take two, pending a successful BWC test suite run 👍

@n1v0lg
Copy link
Contributor

n1v0lg commented Nov 14, 2024

Failure unrelated (CrossClusterSearchUnavailableClusterIT > testSkipUnavailableDependsOnSeeds thread leak)

@n1v0lg
Copy link
Contributor

n1v0lg commented Nov 14, 2024

@elasticmachine update branch

@n1v0lg n1v0lg added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 14, 2024
@cauemarcondes cauemarcondes enabled auto-merge (squash) November 14, 2024 14:29
@n1v0lg
Copy link
Contributor

n1v0lg commented Nov 18, 2024

@elasticmachine update branch plz

@n1v0lg n1v0lg disabled auto-merge November 18, 2024 09:56
@n1v0lg
Copy link
Contributor

n1v0lg commented Nov 18, 2024

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

There are no new commits on the base branch.

@cauemarcondes
Copy link
Contributor Author

@elasticmachine update branch

@cauemarcondes
Copy link
Contributor Author

@elasticmachine update branch

@cauemarcondes cauemarcondes merged commit e019fc0 into elastic:main Nov 18, 2024
19 of 20 checks passed
@cauemarcondes cauemarcondes deleted the remove-apm-user branch November 18, 2024 15:28
elena-shostak added a commit to elastic/kibana that referenced this pull request Nov 19, 2024
## Summary

Cleaned up check for removed `apm_user` role, see
elastic/elasticsearch#116712


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


__Closes:  https://github.com/elastic/kibana/issues/200667__
elena-shostak added a commit to elastic/kibana that referenced this pull request Nov 19, 2024
## Summary

Cleaned up check for removed `apm_user` role, see
elastic/elasticsearch#116712


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


__Closes:  https://github.com/elastic/kibana/issues/200666__

---------

Co-authored-by: Elastic Machine <[email protected]>
cauemarcondes added a commit to elastic/kibana that referenced this pull request Nov 20, 2024
…#200163)

Related to: elastic/elasticsearch#116712

Meta issue: #116760
The apm_user role was
elastic/elasticsearch#68749 in 7.13 and was
supposed to be removed in 8.0.
All mentions of apm_user role were finally removed in
#132790.

This PR adds some deprecation steps for users are using the `apm_user`.

<img width="494" alt="Screenshot 2024-11-18 at 14 10 08"
src="https://github.com/user-attachments/assets/e04fff63-b56e-4a74-93ad-a87884f9a8a6">
<img width="1128" alt="Screenshot 2024-11-18 at 14 10 18"
src="https://github.com/user-attachments/assets/de67afcf-8bd5-4896-815a-4e1adc730681">

<img width="1241" alt="Screenshot 2024-11-14 at 13 12 01"
src="https://github.com/user-attachments/assets/e94b0367-b459-45b4-923e-1de7a095b6b8">
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
## Summary

Cleaned up check for removed `apm_user` role, see
elastic/elasticsearch#116712


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


__Closes:  https://github.com/elastic/kibana/issues/200667__
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
## Summary

Cleaned up check for removed `apm_user` role, see
elastic/elasticsearch#116712


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


__Closes:  https://github.com/elastic/kibana/issues/200666__

---------

Co-authored-by: Elastic Machine <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
…elastic#200163)

Related to: elastic/elasticsearch#116712

Meta issue: elastic#116760
The apm_user role was
elastic/elasticsearch#68749 in 7.13 and was
supposed to be removed in 8.0.
All mentions of apm_user role were finally removed in
elastic#132790.

This PR adds some deprecation steps for users are using the `apm_user`.

<img width="494" alt="Screenshot 2024-11-18 at 14 10 08"
src="https://github.com/user-attachments/assets/e04fff63-b56e-4a74-93ad-a87884f9a8a6">
<img width="1128" alt="Screenshot 2024-11-18 at 14 10 18"
src="https://github.com/user-attachments/assets/de67afcf-8bd5-4896-815a-4e1adc730681">

<img width="1241" alt="Screenshot 2024-11-14 at 13 12 01"
src="https://github.com/user-attachments/assets/e94b0367-b459-45b4-923e-1de7a095b6b8">
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Cleaned up check for removed `apm_user` role, see
elastic/elasticsearch#116712


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


__Closes:  https://github.com/elastic/kibana/issues/200667__
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Cleaned up check for removed `apm_user` role, see
elastic/elasticsearch#116712


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_node:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)


__Closes:  https://github.com/elastic/kibana/issues/200666__

---------

Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…elastic#200163)

Related to: elastic/elasticsearch#116712

Meta issue: elastic#116760
The apm_user role was
elastic/elasticsearch#68749 in 7.13 and was
supposed to be removed in 8.0.
All mentions of apm_user role were finally removed in
elastic#132790.

This PR adds some deprecation steps for users are using the `apm_user`.

<img width="494" alt="Screenshot 2024-11-18 at 14 10 08"
src="https://github.com/user-attachments/assets/e04fff63-b56e-4a74-93ad-a87884f9a8a6">
<img width="1128" alt="Screenshot 2024-11-18 at 14 10 18"
src="https://github.com/user-attachments/assets/de67afcf-8bd5-4896-815a-4e1adc730681">

<img width="1241" alt="Screenshot 2024-11-14 at 13 12 01"
src="https://github.com/user-attachments/assets/e94b0367-b459-45b4-923e-1de7a095b6b8">
@samxbr
Copy link
Contributor

samxbr commented Mar 17, 2025

Friendly reminder that this PR seems to be a breaking change for 9.0, but is missing from the 9.0 release note. We may want to add an entry to the breaking change section of 9.0 release note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >breaking :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team test-full-bwc Trigger full BWC version matrix tests v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants