-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Remove apm_user role #116712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove apm_user role #116712
Conversation
Documentation preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM take two, pending a successful BWC test suite run 👍
Failure unrelated (CrossClusterSearchUnavailableClusterIT > testSkipUnavailableDependsOnSeeds thread leak) |
@elasticmachine update branch |
@elasticmachine update branch plz |
@elasticmachine update branch |
There are no new commits on the base branch. |
@elasticmachine update branch |
@elasticmachine update branch |
## Summary Cleaned up check for removed `apm_user` role, see elastic/elasticsearch#116712 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) __Closes: https://github.com/elastic/kibana/issues/200667__
## Summary Cleaned up check for removed `apm_user` role, see elastic/elasticsearch#116712 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) __Closes: https://github.com/elastic/kibana/issues/200666__ --------- Co-authored-by: Elastic Machine <[email protected]>
…#200163) Related to: elastic/elasticsearch#116712 Meta issue: #116760 The apm_user role was elastic/elasticsearch#68749 in 7.13 and was supposed to be removed in 8.0. All mentions of apm_user role were finally removed in #132790. This PR adds some deprecation steps for users are using the `apm_user`. <img width="494" alt="Screenshot 2024-11-18 at 14 10 08" src="https://github.com/user-attachments/assets/e04fff63-b56e-4a74-93ad-a87884f9a8a6"> <img width="1128" alt="Screenshot 2024-11-18 at 14 10 18" src="https://github.com/user-attachments/assets/de67afcf-8bd5-4896-815a-4e1adc730681"> <img width="1241" alt="Screenshot 2024-11-14 at 13 12 01" src="https://github.com/user-attachments/assets/e94b0367-b459-45b4-923e-1de7a095b6b8">
## Summary Cleaned up check for removed `apm_user` role, see elastic/elasticsearch#116712 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) __Closes: https://github.com/elastic/kibana/issues/200667__
## Summary Cleaned up check for removed `apm_user` role, see elastic/elasticsearch#116712 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) __Closes: https://github.com/elastic/kibana/issues/200666__ --------- Co-authored-by: Elastic Machine <[email protected]>
…elastic#200163) Related to: elastic/elasticsearch#116712 Meta issue: elastic#116760 The apm_user role was elastic/elasticsearch#68749 in 7.13 and was supposed to be removed in 8.0. All mentions of apm_user role were finally removed in elastic#132790. This PR adds some deprecation steps for users are using the `apm_user`. <img width="494" alt="Screenshot 2024-11-18 at 14 10 08" src="https://github.com/user-attachments/assets/e04fff63-b56e-4a74-93ad-a87884f9a8a6"> <img width="1128" alt="Screenshot 2024-11-18 at 14 10 18" src="https://github.com/user-attachments/assets/de67afcf-8bd5-4896-815a-4e1adc730681"> <img width="1241" alt="Screenshot 2024-11-14 at 13 12 01" src="https://github.com/user-attachments/assets/e94b0367-b459-45b4-923e-1de7a095b6b8">
Co-authored-by: Elastic Machine <[email protected]>
## Summary Cleaned up check for removed `apm_user` role, see elastic/elasticsearch#116712 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) __Closes: https://github.com/elastic/kibana/issues/200667__
## Summary Cleaned up check for removed `apm_user` role, see elastic/elasticsearch#116712 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) __Closes: https://github.com/elastic/kibana/issues/200666__ --------- Co-authored-by: Elastic Machine <[email protected]>
…elastic#200163) Related to: elastic/elasticsearch#116712 Meta issue: elastic#116760 The apm_user role was elastic/elasticsearch#68749 in 7.13 and was supposed to be removed in 8.0. All mentions of apm_user role were finally removed in elastic#132790. This PR adds some deprecation steps for users are using the `apm_user`. <img width="494" alt="Screenshot 2024-11-18 at 14 10 08" src="https://github.com/user-attachments/assets/e04fff63-b56e-4a74-93ad-a87884f9a8a6"> <img width="1128" alt="Screenshot 2024-11-18 at 14 10 18" src="https://github.com/user-attachments/assets/de67afcf-8bd5-4896-815a-4e1adc730681"> <img width="1241" alt="Screenshot 2024-11-14 at 13 12 01" src="https://github.com/user-attachments/assets/e94b0367-b459-45b4-923e-1de7a095b6b8">
Friendly reminder that this PR seems to be a breaking change for 9.0, but is missing from the 9.0 release note. We may want to add an entry to the breaking change section of 9.0 release note. |
Meta issue: elastic/kibana#116760
The
apm_user
role was marked as deprecated in 7.13 and was supposed to be removed in 8.0.All mentions of
apm_user
role were finally removed in elastic/kibana#132790 and this PR removes the actual role.