Deserialize deprecated thread pools compatibly with V9 #118492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-ivanov-es
changed the title
alexey-ivanov-es
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
reviewed
Dec 13, 2024
server/src/main/java/org/elasticsearch/threadpool/ThreadPool.java
Outdated
Show resolved
Hide resolved
thecoop
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThreadPoolType.DIRECTandThreadPoolType.FIXED_AUTO_QUEUE_SIZEare deprecated in V8 and will be removed in V9, but the types might still be used in transport messages from earlier versions. This PR ensures that V8.18 can receive messages from earlier versions while still being able to communicate with V9 nodes where the types have been removed