Esql date casting tests #120420
Merged
Esql date casting tests #120420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-napoleon
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
approved these changes
Jan 20, 2025
not-napoleon
added a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Jan 21, 2025
This adds appropriate ignore annotations for the date tests I added in elastic#119772 to not run the tests against very old versions. Should be a no-op for main, but fix some tests in 8.x BWC. Still, I'd rather keep the tests in sync, so I'm applying this to main first. It's not set for auto-backport because I'll need to add the unmutes to the backport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds appropriate ignore annotations for the date tests I added in #119772 to not run the tests against very old versions. Should be a no-op for main, but fix some tests in 8.x BWC. Still, I'd rather keep the tests in sync, so I'm applying this to main first. It's not set for auto-backport because I'll need to add the unmutes to the backport.