Skip listing MPUs if TTL set to -1 #127166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of MinIO will sometimes leak multi-part uploads under concurrent load, leaving them in the `ListMultipartUploads` output even though they cannot be aborted. Today this causes repository analysis to fail since compare-and-exchange operations will not even start if there are any pre-existing uploads. This commit makes it possible to skip this pre-flight check (and accept the performance consequences) by adjusting the relevant settings. Workaround for minio/minio#21189 Closes elastic#122670
DaveCTurner
added
>test
DaveCTurner
requested review from
DiannaHohensee,
JeremyDahlgren and
henningandersen
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
commented
Apr 22, 2025
| .setting("s3.client." + CLIENT + ".endpoint", minioFixture::getAddress) | ||
| // Skip listing of pre-existing uploads during a CAS because MinIO sometimes leaks them; also reduce the delay before proceeding | ||
| // TODO do not set these if running a MinIO version in which https://github.com/minio/minio/issues/21189 is fixed | ||
| .setting(REPOSITORY_S3_CAS_TTL_SETTING.getKey(), "-1") |
There was a problem hiding this comment.
Setting this to -1 (or 0) even without the production code changes would have had pretty much the desired effect anyway because it would make ES consider all the existing uploads as stale, letting it proceed with the CAS. The production code changes just make this behaviour a little more precise, avoiding questions of clock skew and suppressing warnings about the stale uploads etc.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 23, 2025
Recent versions of MinIO will sometimes leak multi-part uploads under concurrent load, leaving them in the `ListMultipartUploads` output even though they cannot be aborted. Today this causes repository analysis to fail since compare-and-exchange operations will not even start if there are any pre-existing uploads. This commit makes it possible to skip this pre-flight check (and accept the performance consequences) by adjusting the relevant settings. Workaround for minio/minio#21189 Closes elastic#122670
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 23, 2025
Recent versions of MinIO will sometimes leak multi-part uploads under concurrent load, leaving them in the `ListMultipartUploads` output even though they cannot be aborted. Today this causes repository analysis to fail since compare-and-exchange operations will not even start if there are any pre-existing uploads. This commit makes it possible to skip this pre-flight check (and accept the performance consequences) by adjusting the relevant settings. Workaround for minio/minio#21189 Closes elastic#122670
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 23, 2025
Recent versions of MinIO will sometimes leak multi-part uploads under concurrent load, leaving them in the `ListMultipartUploads` output even though they cannot be aborted. Today this causes repository analysis to fail since compare-and-exchange operations will not even start if there are any pre-existing uploads. This commit makes it possible to skip this pre-flight check (and accept the performance consequences) by adjusting the relevant settings. Workaround for minio/minio#21189 Closes #122670
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 23, 2025
Recent versions of MinIO will sometimes leak multi-part uploads under concurrent load, leaving them in the `ListMultipartUploads` output even though they cannot be aborted. Today this causes repository analysis to fail since compare-and-exchange operations will not even start if there are any pre-existing uploads. This commit makes it possible to skip this pre-flight check (and accept the performance consequences) by adjusting the relevant settings. Workaround for minio/minio#21189 Closes #122670
DaveCTurner
added a commit
that referenced
this pull request
Apr 23, 2025
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 25, 2025
Earlier versions of MinIO had a bug which can cause repository analysis failures. This commit upgrades the MinIO test container version to pick up the bug fix, and reverts the workaround implemented in elastic#127166. Relates minio/minio#21189
DaveCTurner
added a commit
that referenced
this pull request
May 27, 2025
Earlier versions of MinIO had a bug which can cause repository analysis failures. This commit upgrades the MinIO test container version to pick up the bug fix, and reverts the workaround implemented in #127166. Relates minio/minio#21189
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 27, 2025
Earlier versions of MinIO had a bug which can cause repository analysis failures. This commit upgrades the MinIO test container version to pick up the bug fix, and reverts the workaround implemented in elastic#127166. Relates minio/minio#21189
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 27, 2025
Earlier versions of MinIO had a bug which can cause repository analysis failures. This commit upgrades the MinIO test container version to pick up the bug fix, and reverts the workaround implemented in #127166. Relates minio/minio#21189
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of MinIO will sometimes leak multi-part uploads under
concurrent load, leaving them in the
ListMultipartUploadsoutput eventhough they cannot be aborted. Today this causes repository analysis to
fail since compare-and-exchange operations will not even start if there
are any pre-existing uploads. This commit makes it possible to skip this
pre-flight check (and accept the performance consequences) by adjusting
the relevant settings.
Workaround for minio/minio#21189
Closes #122670