[ObsUX][Profiling] Don't render missing symbols callout when frame type is root #209978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiriamAparicio
added
bug
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
rockdaboot
reviewed
Feb 6, 2025
...lutions/observability/plugins/profiling/public/components/frame_information_window/index.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
rockdaboot
approved these changes
Feb 7, 2025
cauemarcondes
pushed a commit
to cauemarcondes/kibana
that referenced
this pull request
May 2, 2025
…pe is root (elastic#209978) Closes elastic/prodfiler#4386 ### Summary The flyout for the root block always contains the hint "Missing symbols error" because there are no symbols for the root block. We should not show it here. ### What was done Added a condition to not render the callout when frameType is root Before  After Waiting for [this PR](elastic/elasticsearch#119115) to be merged for the condition to work (cherry picked from commit 9e65d7a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cauemarcondes
added a commit
that referenced
this pull request
May 8, 2025
…rame type is root (#209978) (#219964) # Backport This will backport the following commits from `main` to `8.19`: - [[ObsUX][Profiling] Don't render missing symbols callout when frame type is root (#209978)](#209978) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Miriam","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-08T08:31:25Z","message":"[ObsUX][Profiling] Don't render missing symbols callout when frame type is root (#209978)\n\nCloses https://github.com/elastic/prodfiler/issues/4386\r\n\r\n### Summary\r\n\r\nThe flyout for the root block always contains the hint \"Missing symbols\r\nerror\" because there are no symbols for the root block. We should not\r\nshow it here.\r\n\r\n### What was done\r\n\r\nAdded a condition to not render the callout when frameType is root\r\n\r\nBefore\r\n\r\n\r\n\r\n\r\nAfter\r\n\r\nWaiting for [this\r\nPR](elastic/elasticsearch#119115) to be merged\r\nfor the condition to work","sha":"9e65d7a18398877f2721b9b86c69e5fd205e190b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:skip","Team:obs-ux-infra_services","v9.1.0"],"title":"[ObsUX][Profiling] Don't render missing symbols callout when frame type is root","number":209978,"url":"https://github.com/elastic/kibana/pull/209978","mergeCommit":{"message":"[ObsUX][Profiling] Don't render missing symbols callout when frame type is root (#209978)\n\nCloses https://github.com/elastic/prodfiler/issues/4386\r\n\r\n### Summary\r\n\r\nThe flyout for the root block always contains the hint \"Missing symbols\r\nerror\" because there are no symbols for the root block. We should not\r\nshow it here.\r\n\r\n### What was done\r\n\r\nAdded a condition to not render the callout when frameType is root\r\n\r\nBefore\r\n\r\n\r\n\r\n\r\nAfter\r\n\r\nWaiting for [this\r\nPR](elastic/elasticsearch#119115) to be merged\r\nfor the condition to work","sha":"9e65d7a18398877f2721b9b86c69e5fd205e190b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209978","number":209978,"mergeCommit":{"message":"[ObsUX][Profiling] Don't render missing symbols callout when frame type is root (#209978)\n\nCloses https://github.com/elastic/prodfiler/issues/4386\r\n\r\n### Summary\r\n\r\nThe flyout for the root block always contains the hint \"Missing symbols\r\nerror\" because there are no symbols for the root block. We should not\r\nshow it here.\r\n\r\n### What was done\r\n\r\nAdded a condition to not render the callout when frameType is root\r\n\r\nBefore\r\n\r\n\r\n\r\n\r\nAfter\r\n\r\nWaiting for [this\r\nPR](elastic/elasticsearch#119115) to be merged\r\nfor the condition to work","sha":"9e65d7a18398877f2721b9b86c69e5fd205e190b"}}]}] BACKPORT--> Co-authored-by: Miriam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/prodfiler/issues/4386
Summary
The flyout for the root block always contains the hint "Missing symbols error" because there are no symbols for the root block. We should not show it here.
What was done
Added a condition to not render the callout when frameType is root
Before
After
Waiting for this PR to be merged for the condition to work