Upgrade ES client to 9.0.0-alpha.4 #213375

afharo · 2025-03-06T13:05:20Z

Summary

Upgrading the ES client to v9.0.0-alpha.4 to test the changes mentioned in elastic/elasticsearch-js#2584

This new version introduces some type changes, most notably, the FieldValue is string | number | boolean | null | undefined instead of any, leading to some new type checks to be implemented (like on aggregation results bucket.key, search_after, and sort options).

On top of that, it adds the new behavior where unknown properties are placed in the body (when the request has a body). If they must be in as a query parameter, they should be placed under the querystring option.

cc @JoshMock

TODO:

Stabilize the type errors
Address all the query parameters that are now placed in the body (by wrapping them inside the option querystring: {})

I will address // @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584 in a separate PR to reduce noise.

Related #208776

afharo · 2025-03-06T22:03:55Z

src/core/packages/saved-objects/api-server-internal/src/lib/apis/update.ts

@JoshMock, here's a missing query parameter in the spec.

Thanks, I opened elastic/elasticsearch-specification#3954 to add it (plus a bunch of others that were also missing).

afharo · 2025-03-06T22:05:08Z

src/core/packages/saved-objects/api-server-internal/src/lib/apis/create.ts

require_alias is accepted by the IndexRequest but not the CreateRequest, so I went with the querystring passthrough for both here.

baileycash-elastic

Reviewed on behalf of obs-ux-mgmt:
investigate_app
slo
observability-server (?)

changes make sense to me

dgieselaar · 2025-04-03T18:37:04Z

x-pack/solutions/observability/plugins/apm/server/lib/helpers/get_apm_alerts_client.ts

  query?: estypes.QueryDslQueryContainer;
  sort?: estypes.SortOptions[];
  _source?: string[] | false;
+  search_after?: Array<string | number>;


why is this needed?

IIRC, because this way we reduce the actual definition of search_after (which includes boolean and null 🤷 )

kdelemme

LGTM

elasticmachine · 2025-04-03T20:15:53Z

💚 Build Succeeded

Buildkite Build
Commit: 2d83fc2
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-213375-2d83fc2d16b9

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`security`	515.6KB	515.6KB	+5.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`data`	55	56	+1

Total ESLint disabled count

id	before	after	diff
`data`	56	57	+1

History

💛 Build #289869 was flaky 02380db
💚 Build #289558 succeeded c7a8249
💔 Build #289493 failed 35d1b51
💚 Build #288441 succeeded 770d5c9
💛 Build #287631 was flaky 4e7485b

cc @afharo

@ts-expect-error

## Summary Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584. We should be able to remove all usages of `// @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584`.

@ts-expect-error

…217223) ## Summary Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584. We should be able to remove all usages of `// @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584`.

@ts-expect-error

## Summary Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584. We should be able to remove all usages of `// @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584`. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...

@ts-expect-error

…c#217219) ## Summary Follow up to elastic#213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584. We should be able to remove all usages of `// @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584`. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...

@ts-expect-error

## Summary Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584. We should be able to remove all usages of `// @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584`. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

@ts-expect-error

#217225) ## Summary Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584. We should be able to remove all usages of `// @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584`.

@ts-expect-error

## Summary Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584. We should be able to remove all usages of `// @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584`. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

@ts-expect-error

## Summary Follow up to #213375: The latest version of the ES client fixed the issue elastic/elasticsearch-js#2584. We should be able to remove all usages of `// @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584`.

afharo self-assigned this Mar 6, 2025

afharo force-pushed the es-9.0.0-alpha.4 branch from c2a6ef3 to 6cadeaa Compare March 6, 2025 22:02

afharo commented Mar 6, 2025

View reviewed changes

afharo added 4 commits March 10, 2025 11:01

Upgrade ES client to 9.0.0-alpha.4

08bfae4

Fix types 1

f5331db

Fix types 2

a6914f0

client.create doesnt understand require_alias

5768f66

Merge branch 'main' into es-9.0.0-alpha.4

02380db

semd approved these changes Apr 3, 2025

View reviewed changes

sphilipse approved these changes Apr 3, 2025

View reviewed changes

sorenlouv approved these changes Apr 3, 2025

View reviewed changes

baileycash-elastic approved these changes Apr 3, 2025

View reviewed changes

dgieselaar reviewed Apr 3, 2025

View reviewed changes

kdelemme approved these changes Apr 3, 2025

View reviewed changes

Merge branch 'main' into es-9.0.0-alpha.4

2d83fc2

afharo enabled auto-merge (squash) April 3, 2025 19:11

afharo merged commit b5ad8bc into elastic:main Apr 3, 2025
10 checks passed

afharo deleted the es-9.0.0-alpha.4 branch April 3, 2025 20:54

kibanamachine added the v9.1.0 label Apr 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade ES client to 9.0.0-alpha.4 #213375

Upgrade ES client to 9.0.0-alpha.4 #213375

Uh oh!

afharo commented Mar 6, 2025 •

edited

Loading

Uh oh!

afharo Mar 6, 2025

Uh oh!

pquentin Mar 13, 2025

Uh oh!

afharo Mar 6, 2025

Uh oh!

baileycash-elastic left a comment

Uh oh!

dgieselaar Apr 3, 2025

Uh oh!

afharo Apr 3, 2025

Uh oh!

kdelemme left a comment

Uh oh!

elasticmachine commented Apr 3, 2025 •

edited

Loading

ESLint disabled line counts

Total ESLint disabled count

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

30 participants

Upgrade ES client to 9.0.0-alpha.4 #213375

Upgrade ES client to 9.0.0-alpha.4 #213375

Uh oh!

Conversation

afharo commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

afharo Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

pquentin Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

afharo Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

baileycash-elastic left a comment

Choose a reason for hiding this comment

Uh oh!

dgieselaar Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

afharo Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

kdelemme left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

30 participants

afharo commented Mar 6, 2025 •

edited

Loading

elasticmachine commented Apr 3, 2025 •

edited

Loading