Skip to content

[DOCS] Use new ML and transform URLs in doc link service #217930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 21, 2025
Merged

[DOCS] Use new ML and transform URLs in doc link service #217930

merged 10 commits into from
Apr 21, 2025

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 11, 2025 •
edited by kibanamachine
Loading

Relates to #217722

This PR:

  • updates the doc link service to use the appropriate URLs for ml, transform, and inferenceManagement URLS in the new doc system
  • simplifies some URLs in the doc link service for which we previously had separate serverless and stack docs, since those pages have been consolidated in the new doc system
  • updates the URLs in messages.test.ts

NOTE: If there's a better way to avoid repeating the URLs in the messages.test.ts file (in case they change again), that would be great.

@lcawl lcawl added Team:Docs release_note:skip Skip the PR/issue when compiling release notes docs backport:version Backport to applied version labels v9.1.0 v9.0.1 labels Apr 11, 2025
@lcawl lcawl marked this pull request as ready for review April 11, 2025 02:11
@lcawl lcawl requested a review from a team as a code owner April 11, 2025 02:11
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 11, 2025

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl mentioned this pull request Apr 11, 2025
Closed
12 tasks
@lcawl lcawl marked this pull request as draft April 11, 2025 23:54
@lcawl lcawl marked this pull request as ready for review April 12, 2025 01:41
@lcawl lcawl requested a review from a team as a code owner April 12, 2025 01:42
@rbrtj rbrtj self-requested a review April 14, 2025 16:52
rbrtj
rbrtj approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@rbrtj rbrtj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated messages.test.ts to reduce code repetition. Not sure if there's anything else we can do here

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 17, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 63.9KB 65.6KB +1.7KB
lists 110.6KB 112.3KB +1.7KB
total +3.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 435.5KB 437.1KB +1.7KB

History

@lcawl lcawl enabled auto-merge (squash) April 21, 2025 18:36
@lcawl lcawl mentioned this pull request Apr 21, 2025
Merged
@lcawl lcawl merged commit 4e6fa9e into elastic:main Apr 21, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 21, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14580528219

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 21, 2025

💔 All backports failed

Status Branch Result
❌ 9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- [Security Solution] [Detections] Clarify result of missing read-index privileges on index patterns for a given rule (#215941)
- Update API URLs in doc link service (#215084)
- [Core][UA] Forward-port 8.18 changes into main (#214996)

Manual backport

To create the backport manually run:

node scripts/backport --pr 217930

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl deleted the ml-doc-links branch April 21, 2025 21:22
pgayvallet pushed a commit to pgayvallet/kibana that referenced this pull request Apr 22, 2025
@lcawl @rbrtj @pgayvallet
[DOCS] Use new ML and transform URLs in doc link service (elastic#217930
142b137 
)

Co-authored-by: Robert Jaszczurek <[email protected]>
@lcawl lcawl mentioned this pull request Apr 22, 2025
Merged
@lcawl
Copy link
Contributor Author

lcawl commented Apr 22, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/kibana that referenced this pull request Apr 22, 2025
@lcawl @rbrtj
[DOCS] Use new ML and transform URLs in doc link service (elastic#217930
62ad9d5 
)

Co-authored-by: Robert Jaszczurek <[email protected]>
(cherry picked from commit 4e6fa9e)
lcawl added a commit that referenced this pull request Apr 23, 2025
@lcawl
[9.0] [DOCS] Use new ML and transform URLs in doc link service (#217930…
112b286 
…) (#218892)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[DOCS] Use new ML and transform URLs in doc link service
(#217930)](#217930)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-21T20:09:43Z","message":"[DOCS]
Use new ML and transform URLs in doc link service
(#217930)\n\n\nCo-authored-by: Robert Jaszczurek
<[email protected]>","sha":"4e6fa9e37f7390a86b0f38f8981fbf9eb1f0751b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","backport:version","v9.1.0","v9.0.1"],"title":"[DOCS]
Use new ML and transform URLs in doc link
service","number":217930,"url":"https://github.com/elastic/kibana/pull/217930","mergeCommit":{"message":"[DOCS]
Use new ML and transform URLs in doc link service
(#217930)\n\n\nCo-authored-by: Robert Jaszczurek
<[email protected]>","sha":"4e6fa9e37f7390a86b0f38f8981fbf9eb1f0751b"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217930","number":217930,"mergeCommit":{"message":"[DOCS]
Use new ML and transform URLs in doc link service
(#217930)\n\n\nCo-authored-by: Robert Jaszczurek
<[email protected]>","sha":"4e6fa9e37f7390a86b0f38f8981fbf9eb1f0751b"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@lcawl @rbrtj @akowalska622
[DOCS] Use new ML and transform URLs in doc link service (elastic#217930
7319968 
)

Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbrtj rbrtj rbrtj approved these changes

@wajihaparvez wajihaparvez wajihaparvez approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lcawl @elasticmachine @kibanamachine @rbrtj @wajihaparvez