Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 12, 2025

Relates to #217722

This PR updates the doc link service to use the appropriate URLs for apm, observability, and monitoring URLS in the new doc system. It also fixes the URL in the Uptime OpenAPI document and regenerates the Kibana OpenAPI document with that information.

The jest tests were fixed and re-tested as follows:

yarn test:jest -u src/platform/plugins/shared/ai_assistant_management/selection/public/routes/components/ai_assistant_selection_page.test.tsx

@lcawl lcawl added Team:Docs release_note:skip Skip the PR/issue when compiling release notes docs backport:version Backport to applied version labels v9.1.0 v9.0.1 labels Apr 12, 2025
@lcawl lcawl marked this pull request as ready for review April 14, 2025 18:04
@lcawl lcawl requested a review from a team as a code owner April 14, 2025 18:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl requested a review from a team as a code owner April 21, 2025 18:58
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Apr 21, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl enabled auto-merge (squash) April 28, 2025 22:52
@lcawl lcawl requested a review from a team as a code owner May 1, 2025 14:27
@prodsecmachine
Copy link
Collaborator

prodsecmachine commented May 1, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs ux management changes LGTM

@lcawl
Copy link
Contributor Author

lcawl commented May 7, 2025

@neptunian Since you approved #219005 would you be willing to take a gander at this one too?

@elasticmachine
Copy link
Contributor

elasticmachine commented May 8, 2025

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: e2d6b51
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-218030-e2d6b51f376c

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #62 / Cloud Security Posture Vulnerabilities Page - Grouping Default Grouping groups vulnerabilities by cloud account and sort by number of vulnerabilities desc

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 74.1KB 74.6KB +489.0B
lists 120.8KB 121.3KB +489.0B
total +978.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 437.1KB 437.6KB +489.0B

History

@lcawl lcawl merged commit d91af7a into elastic:main May 9, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14918766283

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 218030

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl deleted the observability-links branch May 9, 2025 04:16
lcawl added a commit to lcawl/kibana that referenced this pull request May 9, 2025
@lcawl
Copy link
Contributor Author

lcawl commented May 9, 2025

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request May 9, 2025
) (#220606)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[DOCS] Update URLs for apm, monitoring, and observability
(#218030)](#218030)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-09T00:29:43Z","message":"[DOCS]
Update URLs for apm, monitoring, and observability
(#218030)\n\n\nCo-authored-by: florent-leborgne
<[email protected]>","sha":"d91af7ad7dbf702effb1602e746c401d492fd2f5","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","ci:project-deploy-observability","backport:version","v9.1.0","v9.0.1"],"title":"[DOCS]
Update URLs for apm, monitoring, and
observability","number":218030,"url":"https://github.com/elastic/kibana/pull/218030","mergeCommit":{"message":"[DOCS]
Update URLs for apm, monitoring, and observability
(#218030)\n\n\nCo-authored-by: florent-leborgne
<[email protected]>","sha":"d91af7ad7dbf702effb1602e746c401d492fd2f5"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218030","number":218030,"mergeCommit":{"message":"[DOCS]
Update URLs for apm, monitoring, and observability
(#218030)\n\n\nCo-authored-by: florent-leborgne
<[email protected]>","sha":"d91af7ad7dbf702effb1602e746c401d492fd2f5"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: florent-leborgne <[email protected]>
kdelemme pushed a commit to kdelemme/kibana that referenced this pull request May 9, 2025
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v9.0.1 v9.0.2 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants