Skip to content

Use new beat URLs in doc link service #219310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 9, 2025
Merged

Use new beat URLs in doc link service #219310

merged 13 commits into from
May 9, 2025

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 25, 2025 •
edited by kibanamachine
Loading

Summary

Relates to #217722

This PR updates the URLs in the fleet, filebeat, metricbeat, auditbeat, heartbeat, libbeat, and winlogbeat sections of the Kibana doc links service.

It also adds a new entry in the doc link service, to fix a partial URL in x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/common/monitor_tags.tsx.

Jest tests were addressed with the following commands:

yarn test:jest -u x-pack/solutions/security/plugins/security_solution/public/explore/network/components/embeddables/index_patterns_missing_prompt.test.tsx
yarn test:jest -u x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/monitor/status_details/__snapshots__/monitor_status.bar.test.tsx

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@lcawl lcawl added Team:Docs release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v9.0.1 labels Apr 25, 2025
@lcawl lcawl marked this pull request as ready for review April 25, 2025 19:51
@lcawl lcawl requested a review from a team as a code owner April 25, 2025 19:51
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 25, 2025

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl mentioned this pull request Apr 25, 2025
Closed
12 tasks
@lcawl lcawl requested review from a team as code owners April 29, 2025 14:43
@dominiqueclarke dominiqueclarke added ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-observability Create an Observability project labels May 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

wajihaparvez
wajihaparvez approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@wajihaparvez wajihaparvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dominiqueclarke
dominiqueclarke approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs-ux-management changes LGTM

@lcawl lcawl enabled auto-merge (squash) May 7, 2025 02:07
@elasticmachine
Copy link
Contributor

elasticmachine commented May 9, 2025 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 74.6KB 75.1KB +587.0B
lists 121.3KB 121.8KB +587.0B
uptime 486.0KB 486.0KB -32.0B
total +1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 437.6KB 438.2KB +587.0B

History

@lcawl lcawl merged commit 5b00559 into elastic:main May 9, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented May 9, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14926454468

@kibanamachine
Copy link
Contributor

kibanamachine commented May 9, 2025

💔 All backports failed

Status Branch Result
❌ 9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- [DOCS] Update URLs for apm, monitoring, and observability (#218030)
- Update Elasticsearch URLs in doc link service (#219656)
- [Core][UA] Forward-port 8.18 changes into main (#214996)

Manual backport

To create the backport manually run:

node scripts/backport --pr 219310

Questions ?

Please refer to the Backport tool documentation

kdelemme pushed a commit to kdelemme/kibana that referenced this pull request May 9, 2025
@lcawl @kdelemme
Use new beat URLs in doc link service (elastic#219310)
bef404f
@lcawl lcawl deleted the beat-links branch May 9, 2025 21:01
lcawl added a commit to lcawl/kibana that referenced this pull request May 9, 2025
@lcawl
Use new beat URLs in doc link service (elastic#219310)
3a4a492 
(cherry picked from commit 5b00559)
@lcawl lcawl mentioned this pull request May 9, 2025
Merged
@lcawl
Copy link
Contributor Author

lcawl commented May 9, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 13, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented May 13, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @lcawl

6 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented May 14, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @lcawl

@kibanamachine
Copy link
Contributor

kibanamachine commented May 15, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @lcawl

@kibanamachine
Copy link
Contributor

kibanamachine commented May 16, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @lcawl

@kibanamachine
Copy link
Contributor

kibanamachine commented May 19, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @lcawl

@kibanamachine
Copy link
Contributor

kibanamachine commented May 20, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @lcawl

@kibanamachine
Copy link
Contributor

kibanamachine commented May 21, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @lcawl

lcawl added a commit that referenced this pull request May 21, 2025
@lcawl
[9.0] Use new beat URLs in doc link service (#219310) (#220721)
d57c649 
# Backport

This will backport the following commits from `main` to `9.0`:
- [Use new beat URLs in doc link service
(#219310)](#219310)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-09T10:01:39Z","message":"Use
new beat URLs in doc link service
(#219310)","sha":"5b005594cc8c231b24934bd3c4f8c2593c3561f6","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","ci:cloud-deploy","ci:project-deploy-observability","backport:version","v9.1.0","v9.0.1"],"title":"Use
new beat URLs in doc link
service","number":219310,"url":"https://github.com/elastic/kibana/pull/219310","mergeCommit":{"message":"Use
new beat URLs in doc link service
(#219310)","sha":"5b005594cc8c231b24934bd3c4f8c2593c3561f6"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219310","number":219310,"mergeCommit":{"message":"Use
new beat URLs in doc link service
(#219310)","sha":"5b005594cc8c231b24934bd3c4f8c2593c3561f6"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine added v9.0.2 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels May 21, 2025
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@lcawl @akowalska622
Use new beat URLs in doc link service (elastic#219310)
83c7b75
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
@lcawl @qn895
Use new beat URLs in doc link service (elastic#219310)
4ee0228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@semd semd semd approved these changes

@wajihaparvez wajihaparvez wajihaparvez approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Docs v9.0.1 v9.0.2 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lcawl @elasticmachine @kibanamachine @dominiqueclarke @semd @wajihaparvez