-
Notifications
You must be signed in to change notification settings - Fork 36
Various updates to EDOT Node.js docs #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update deep links to opentelemetry-js-contrib due to directory moves in that repo.
- Supported technologies table updates:
- Point to instrumentation-redis rather than instrumentation-redis-4. The former was accidentally not included, and the latter is now rolled into the former (elastic/elastic-otel-node#889).
- Mention some included instrumentations that were missing from this table: connect, cucumber, dns, runtime-node
Fixes: elastic/elastic-otel-node#869
Refs: elastic/elastic-otel-node#889 (review)
|
@theletterf (/cc @Mpdreamz) what do I do about this docs-build crash? https://github.com/elastic/opentelemetry/actions/runs/16578203972/job/46887665165?pr=375 I assume this is because I added a few rows to this existing Markdown table: https://github.com/elastic/opentelemetry/pull/375/files#diff-0beabc8fec73e207ac0aec1a40e68c8a65306e9848186d4a11eda2375825c677R47 FWIW, GitHub renders it fine: https://github.com/elastic/opentelemetry/blob/trentm-edot-node-updates/docs/reference/edot-sdks/nodejs/supported-technologies.md#instrumentations-instrumentations I look more carefully to see if I made a Markdown syntax error in my changes, but from the error message is feels like I just hit it with too big of a table? |
|
If we need a short term workaround, it would be fine to exclude a few of the rows for less important instrumentations. |
Co-authored-by: Colleen McGinnis <[email protected]>
theletterf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes: elastic/elastic-otel-node#869
Refs: elastic/elastic-otel-node#889 (review)