-
Notifications
You must be signed in to change notification settings - Fork 56
Document how to setup Discord as upstream OAuth 2.0 provider, add missing token_endpoint_auth_method
field in GitHub sample config
#4310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've added sample upstream config for Discord, and a brand logo svg. Probably should have been a separate PR... |
template: "{{ user.preferred_username }}" | ||
``` | ||
|
||
### Discord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd appreciate this to be either in a separate PR, or if you renamed the PR accordingly (as this is what ends up in the changelog)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed the PR. Will try to keep it cleaner next time..
providers: | ||
- id: 01JQK7DK6VFH62NMW4HS9RKD3R | ||
human_name: Discord | ||
brand_name: "discord" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this in the comment here:
matrix-authentication-service/crates/config/src/sections/upstream_oauth2.rs
Lines 424 to 436 in bcaa783
/// A brand identifier used to customise the UI, e.g. `apple`, `google`, | |
/// `github`, etc. | |
/// | |
/// Values supported by the default template are: | |
/// | |
/// - `apple` | |
/// - `google` | |
/// - `facebook` | |
/// - `github` | |
/// - `gitlab` | |
/// - `twitter` | |
#[serde(skip_serializing_if = "Option::is_none")] | |
pub brand_name: Option<String>, |
and then regenerate the config schema with sh misc/update.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
token_endpoint_auth_method
field in GitHub sample config
The sample config for Github is missing the
token_endpoint_auth_method
field. Mas-cli won't sync config unless the field exists, and errors with:Adding
token_endpoint_auth_method: "client_secret_post"
fixes it.