Document how to setup Discord as upstream OAuth 2.0 provider, add missing token_endpoint_auth_method field in GitHub sample config
#4310
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -339,6 +339,7 @@ upstream_oauth2: | |
| human_name: Google | ||
| brand_name: "google" | ||
| issuer: "https://accounts.google.com" | ||
| token_endpoint_auth_method: "client_secret_post" | ||
| client_id: "<client-id>" # TO BE FILLED | ||
| client_secret: "<client-secret>" # TO BE FILLED | ||
| scope: "openid profile email" | ||
|
|
@@ -451,6 +452,40 @@ upstream_oauth2: | |
| template: "{{ user.preferred_username }}" | ||
| ``` | ||
|
|
||
| ### Discord | ||
|
|
||
| 1. Create a new application in the Discord Developer Portal (see [documentation](https://discord.com/developers/applications)) | ||
| 2. Add the following "Redirect URI" in the OAuth2 tab under settings: `https://<auth-service-domain>/upstream/callback/<id>` | ||
|
|
||
| Authentication service configuration: | ||
|
|
||
| ```yaml | ||
| upstream_oauth2: | ||
| providers: | ||
| - id: 01JQK7DK6VFH62NMW4HS9RKD3R | ||
| human_name: Discord | ||
| brand_name: "discord" | ||
|
There was a problem hiding this comment. Could you add this in the comment here: matrix-authentication-service/crates/config/src/sections/upstream_oauth2.rs Lines 424 to 436 in bcaa783 and then regenerate the config schema with |
||
| token_endpoint_auth_method: "client_secret_post" | ||
| issuer: "https://discord.com" | ||
| client_id: "<client-id>" # TO BE FILLED | ||
| client_secret: "<client-secret>" # TO BE FILLED | ||
| fetch_userinfo: true | ||
| userinfo_endpoint: "https://discord.com/api/users/@me" | ||
| scope: "openid identify email" | ||
| claims_imports: | ||
| localpart: | ||
| action: suggest | ||
| template: "{{ user.username }}" | ||
| displayname: | ||
| action: suggest | ||
| template: "{{ user.global_name }}" | ||
| email: | ||
| action: suggest | ||
| template: "{{ user.email }}" | ||
| account_name: | ||
| template: "{{ user.username }}" | ||
| ``` | ||
|
|
||
|
|
||
| ### Rauthy | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd appreciate this to be either in a separate PR, or if you renamed the PR accordingly (as this is what ends up in the changelog)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed the PR. Will try to keep it cleaner next time..