Fix dialyzer opaqueness warnings on module attrs in OTP28 #14755
Conversation
sabiwara
changed the title
sabiwara
changed the title
|
I wonder if instead we should do |
I thought about it too, yeah it sounds good! |
| * `:generated` - (since v1.19.0) Whether the AST should be considered as generated | ||
| by the compiler or not. This means the compiler and tools like Dialyzer may not | ||
| emit certain warnings. |
There was a problem hiding this comment.
Basically the same as https://hexdocs.pm/elixir/1.19.0-rc.0/Macro.html#t:metadata/0
| {caller, meta, args} when generated and is_list(meta) -> | ||
| {caller, [generated: true] ++ meta, args} |
There was a problem hiding this comment.
Should we wrap with a __block__ for other ASTs?
It feels a bit too much, we shouldn't need it for this use case and quote doesn't do it either.
There was a problem hiding this comment.
I think there is no need, yeah.
sabiwara
force-pushed
the
generated-escape
branch
from
fd96bab to
c351990
Compare
* Mark module attributes as generated in case they contain opaque terms * Add and use Macro.escape(ast, generated: true)
|
Backported ✅ |
| nodes. Note this option changes the semantics of escaped code and | ||
| it should only be used when escaping ASTs. Defaults to `false`. | ||
| * `:generated` - (since v1.19.0) Whether the AST should be considered as generated |
3 participants
Marks module attributes as generated in case they contain opaque terms
Close #14750
To be backported to 1.19