Upgrade freetype port from 2.6 to 2.13.3 #22585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
commented
Sep 18, 2024
| ****** ***** | ||
| +****+ +**** | ||
| +****+ +**** | ||
| **** **** |
There was a problem hiding this comment.
It looks like the rendering is slightly thinner with the new version.. do you think this kind of change is normal/acceptable when upgrading freetype.
There was a problem hiding this comment.
Yeah, it's intentional on the FT side, I assume.
sbc100
force-pushed
the
update_freetype
branch
from
a353343 to
b668457
Compare
sbc100
force-pushed
the
update_freetype
branch
from
b668457 to
078e330
Compare
kripken
approved these changes
Sep 18, 2024
| ****** ***** | ||
| +****+ +**** | ||
| +****+ +**** | ||
| **** **** |
There was a problem hiding this comment.
Yeah, it's intentional on the FT side, I assume.
sbc100
force-pushed
the
update_freetype
branch
from
078e330 to
50062a6
Compare
sbc100
force-pushed
the
update_freetype
branch
3 times, most recently
from
3fd8daa to
e2e298d
Compare
|
reftests updated. PTAL. |
sbc100
force-pushed
the
update_freetype
branch
from
e2e298d to
4f7b0e8
Compare
Also, switch from a fork to using the upstream github repo. We had a single patch in our fork: emscripten-ports/FreeType@40a760c However, this was upstreamed in: freetype/freetype@2f4b740 This change is based on emscripten-core#18088. Fixes: emscripten-core#22571
sbc100
force-pushed
the
update_freetype
branch
from
4f7b0e8 to
def27ab
Compare
|
This seems to be failing on the Chromium Windows bot: https://ci.chromium.org/ui/p/emscripten-releases/builders/try/win/b8736319351635088817/overview I haven't tried to repro locally, but let me know if you need me to; i do have a windows cloudtop. |
Thanks, I'll take a look. |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 20, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 20, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 20, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 20, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 20, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 20, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 20, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 20, 2024
The subprocess creation on windows really doesn't like it when an argument contains < or >. Instead of trying to defined `FT_CONFIG_CONFIG_H` or point to our own version, just overwrite the default version. See emscripten-core#22585 (comment)
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 20, 2024
The subprocess creation on windows really doesn't like it when an argument contains < or >. Instead of trying to defined `FT_CONFIG_CONFIG_H` or point to our own version, just overwrite the default version. See emscripten-core#22585 (comment)
dschuff
added a commit
that referenced
this pull request
Sep 23, 2024
The subprocess creation on windows really doesn't like it when an argument contains < or >. Instead use the default `FT_CONFIG_CONFT_CONFIG_CONFIG_H` and define the two `HAVE_` macros on the command line. See #22585 (comment) --------- Co-authored-by: Derek Schuff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, switch from a fork to using the upstream github repo. We had a single patch in our fork:
emscripten-ports/FreeType@40a760c
However, this was upstreamed in:
freetype/freetype@2f4b740
This change is based on #18088.
Fixes: #22571