[embind] Change how the number of arguments are verified. #22591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Sep 19, 2024
| assert.equal(-1, value); | ||
| }); | ||
|
|
||
| test("std::optional args can be omitted", function() { |
There was a problem hiding this comment.
How about arguments that have default values?
There was a problem hiding this comment.
Embind doesn't really support default C++ arguments. Functions with default arguments just look like regular functions to embind. e.g. foo(int a = 100) is just foo(int a) in embind's view of things.
| if (arguments.length !== ${argCount}) { | ||
| throwBindingError('function ' + humanName + ' called with ' + arguments.length + ' arguments, expected ${argCount}'); | ||
| }`; | ||
| var invokerFnBody = `return function (${argsList}) {\n`; |
There was a problem hiding this comment.
As a followup can this be arrow function in some cases?
There was a problem hiding this comment.
I'll look into it. This is also used in constructors so having the scope bound, may be an issue.
kripken
reviewed
Sep 19, 2024
kripken
approved these changes
Sep 19, 2024
This is really two changes, but they both will affect the same code so I did them at once: - The number of arguments is now only verified with ASSERTIONS enabled. This will help code size and the speed of embind invoker functions. - Allow optional arguments to be omitted. Fixes emscripten-core#22389
brendandahl
force-pushed
the
embind-args
branch
from
b427b4e to
13b11be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really two changes, but they both will affect the same code so I did them at once:
Fixes #22389