Remove expectation of no non-debug custom sections in separate-dwarf files #22821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-dwarf files This test is now failing after WebAssembly/binaryen#7043 because the target_features section is in the output binary and gets copied over to the separate-dwarf file (this is because the separate-dwarf file is just a copy of the original file). An alternative to this would be to strip all non-debug custom sections from the side file, although there could be sections that emscripten doesn't know about that it would be desirable to have.
dschuff
changed the title
dschuff
force-pushed
the
no_expect_custom
branch
from
5976ec7 to
e6dcb15
Compare
dschuff
commented
Oct 31, 2024
| # self.fail(f'section of type "{sec.type}" found in separate dwarf file') | ||
| if sec.name and sec.name != 'name' and not sec.name.startswith('.debug'): | ||
| self.fail(f'non-debug section "{sec.name}" found in separate dwarf file') | ||
| pass |
Member
Author
There was a problem hiding this comment.
oops, this is now very ugly. I just reopened #13084 again. If you'd prefer we can just delete this whole for loop until it gets fixed.
Member
There was a problem hiding this comment.
I'm ok with it is as is. There is a TODO so it's clear the code is meant to be fixed up later.
kripken
approved these changes
Oct 31, 2024
| # self.fail(f'section of type "{sec.type}" found in separate dwarf file') | ||
| if sec.name and sec.name != 'name' and not sec.name.startswith('.debug'): | ||
| self.fail(f'non-debug section "{sec.name}" found in separate dwarf file') | ||
| pass |
Member
There was a problem hiding this comment.
I'm ok with it is as is. There is a TODO so it's clear the code is meant to be fixed up later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is now failing after WebAssembly/binaryen#7043 because the target_features section is in the output binary and gets copied over to the separate-dwarf file (this is because the separate-dwarf file is just a copy of the original file).
An alternative to this would be to strip all non-debug custom sections from the side file, although there could be sections that emscripten doesn't know about that it would be desirable to have.