Skip to content

Remove expectation of no non-debug custom sections in separate-dwarf files #22821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Remove expectation of no non-debug custom sections in separate-dwarf files #22821

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e501828
Remove expectation requiring no non-debug custom sections in separate…
dschuff Oct 31, 2024
e6dcb15
fix pass
dschuff Oct 31, 2024
ba1f57d
Fix flake8
dschuff Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10220,14 +10220,13 @@ def test_separate_dwarf(self):
with webassembly.Module('subdir/output.wasm.debug.wasm') as debug_wasm:
if not debug_wasm.has_name_section():
self.fail('name section not found in separate dwarf file')
for sec in debug_wasm.sections():
for _sec in debug_wasm.sections():
# TODO(https://github.com/emscripten-core/emscripten/issues/13084):
# Re-enable this code once the debugger extension can handle wasm files
# with name sections but no code sections.
# if sec.type == webassembly.SecType.CODE:
# self.fail(f'section of type "{sec.type}" found in separate dwarf file')
if sec.name and sec.name != 'name' and not sec.name.startswith('.debug'):
self.fail(f'non-debug section "{sec.name}" found in separate dwarf file')
pass
Copy link
Member Author

@dschuff dschuff Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, this is now very ugly. I just reopened #13084 again. If you'd prefer we can just delete this whole for loop until it gets fixed.

Copy link
Member

@kripken kripken Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with it is as is. There is a TODO so it's clear the code is meant to be fixed up later.


# Check that dwarfdump can dump the debug info
dwdump = self.run_process(
Expand Down
Loading