-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[file_packager] Convert fetchRemotePackage to async. NFC #24893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+81
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkwinta
reviewed
Aug 8, 2025
e5efcc8
to
13305e0
Compare
kripken
reviewed
Aug 8, 2025
13305e0
to
f874811
Compare
kripken
approved these changes
Aug 8, 2025
RReverser
reviewed
Aug 9, 2025
RReverser
reviewed
Aug 9, 2025
f874811
to
6d48d48
Compare
RReverser
reviewed
Aug 9, 2025
RReverser
reviewed
Aug 9, 2025
lkwinta
approved these changes
Aug 9, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 11, 2025
This argument has been used since 3839dd4. Even when this function was first add in 74f3242 the errback callback was only used for the IDB failures, not the fetch failures. Fetch failure were left to propagate to the global error handlers. This is small cleanup in advance of emscripten-core#24893.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 11, 2025
This argument has been used since 3839dd4. Even when this function was first add in 74f3242 the errback callback was only used for the IDB failures, not the fetch failures. Fetch failure were left to propagate to the global error handlers. This is small cleanup in advance of emscripten-core#24893.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 11, 2025
This argument has basically used since 3839dd4. Even when this function was first add in 74f3242 the errback callback was only used for the IDB failures, not the fetch failures. Fetch failure were left to propagate to the global error handlers. The exception here was that when node support was added in emscripten-core#11785 it, I believe incorrectly used errback to handle file read errors (doesn't match the web version that does *not* handle fetch error using errback). This is small cleanup in advance of emscripten-core#24893.
sbc100
added a commit
that referenced
this pull request
Aug 11, 2025
This argument has been used since 3839dd4. Even when this function was first added in 74f3242, `errback` was only used for the IDB failures, not the fetch failures. Fetch failure were left to propagate to the global error handlers. The exception here was that when node support was added in #11785 it, I believe incorrectly used errback to handle file read errors (doesn't match the web version that does *not* handle fetch error using errback). I'm not claiming this is correct/best behaviour, this is simply an NFC to cleanup an already-unused argument. This is small cleanup in advance of #24893.
6d48d48
to
88f4523
Compare
Part 4 in the sequence following emscripten-core#24882, emscripten-core#24883 and emscripten-core#24885.
88f4523
to
13603a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 4 in the sequence following #24882, #24883 and #24885.