Skip to content

[file_packager] Convert fetchRemotePackage to async. NFC #24893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 8, 2025

Part 4 in the sequence following #24882, #24883 and #24885.

@sbc100 sbc100 requested a review from kripken August 8, 2025 21:14
@sbc100 sbc100 changed the title [file_packages] Convert fetchRemotePackage to async. NFC [file_packager] Convert fetchRemotePackage to async. NFC Aug 8, 2025
@sbc100 sbc100 force-pushed the file_packager_async_part4 branch 4 times, most recently from e5efcc8 to 13305e0 Compare August 8, 2025 23:00
@sbc100 sbc100 force-pushed the file_packager_async_part4 branch from 13305e0 to f874811 Compare August 8, 2025 23:16
@sbc100 sbc100 requested review from kripken and lkwinta August 8, 2025 23:38
@sbc100 sbc100 force-pushed the file_packager_async_part4 branch from f874811 to 6d48d48 Compare August 9, 2025 14:30
sbc100 added a commit to sbc100/emscripten that referenced this pull request Aug 11, 2025
This argument has been used since 3839dd4.

Even when this function was first add in 74f3242 the errback
callback was only used for the IDB failures, not the fetch failures.
Fetch failure were left to propagate to the global error handlers.

This is small cleanup in advance of emscripten-core#24893.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Aug 11, 2025
This argument has been used since 3839dd4.

Even when this function was first add in 74f3242 the errback
callback was only used for the IDB failures, not the fetch failures.
Fetch failure were left to propagate to the global error handlers.

This is small cleanup in advance of emscripten-core#24893.
sbc100 added a commit to sbc100/emscripten that referenced this pull request Aug 11, 2025
This argument has basically used since 3839dd4.

Even when this function was first add in 74f3242 the errback
callback was only used for the IDB failures, not the fetch failures.
Fetch failure were left to propagate to the global error handlers.

The exception here was that when node support was added in emscripten-core#11785 it,
I believe incorrectly used errback to handle file read errors (doesn't
match the web version that does *not* handle fetch error using errback).

This is small cleanup in advance of emscripten-core#24893.
sbc100 added a commit that referenced this pull request Aug 11, 2025
This argument has been used since 3839dd4.

Even when this function was first added in 74f3242, `errback` was
only used for the IDB failures, not the fetch failures. Fetch failure
were left to propagate to the global error handlers.

The exception here was that when node support was added in #11785 it, I
believe incorrectly used errback to handle file read errors (doesn't
match the web version that does *not* handle fetch error using errback).

I'm not claiming this is correct/best behaviour, this is simply an NFC
to cleanup an already-unused argument.

This is small cleanup in advance of #24893.
@sbc100 sbc100 force-pushed the file_packager_async_part4 branch from 6d48d48 to 88f4523 Compare August 11, 2025 21:35
@sbc100 sbc100 force-pushed the file_packager_async_part4 branch from 88f4523 to 13603a8 Compare August 12, 2025 16:10
@sbc100 sbc100 enabled auto-merge (squash) August 12, 2025 16:10
@sbc100 sbc100 merged commit 889fda2 into emscripten-core:main Aug 12, 2025
30 checks passed
@sbc100 sbc100 deleted the file_packager_async_part4 branch August 12, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants