C61: Add GPIO support, enable HIL test#5248
Merged
bugadani merged 6 commits intoesp-rs:mainfrom Mar 25, 2026
Merged
Conversation
Merged
bjoernQ
approved these changes
Mar 25, 2026
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
I guess there are a few examples we could enable now, for ESP32-C61, too
bugadani
reviewed
Mar 25, 2026
esp-metadata/devices/esp32c61.toml
Outdated
Comment on lines
+218
to
+219
| { pin = 8, functions = { 2 = "FSPICS0" }, limitations = ["strapping"] }, | ||
| { pin = 9, limitations = ["strapping"] }, |
Contributor
There was a problem hiding this comment.
Perhaps we should add the ZCD analog functions to these (zero-crossing detector), which are analog voltage comparator pin functions.
Contributor
There was a problem hiding this comment.
Also, some of the limitations fields are a bit misaligned :)
bugadani
reviewed
Mar 25, 2026
Comment on lines
+271
to
+272
| { name = "U2RXD", id = 72 }, | ||
| { name = "U2CTS", id = 73 }, |
Contributor
There was a problem hiding this comment.
This chip has 2 uarts, what are these for? 😅
bugadani
reviewed
Mar 25, 2026
Comment on lines
+334
to
+335
| { name = "FSPICS5", id = 106 }, | ||
| { name = "GPIO", id = 256 }, |
Contributor
There was a problem hiding this comment.
Suggested change
| { name = "FSPICS5", id = 106 }, | |
| { name = "GPIO", id = 256 }, | |
| { name = "FSPICS5", id = 106 }, | |
| { name = "SDIO_TOHOST_INT_OUT", id = 124 }, | |
| { name = "GPIO", id = 256 }, |
bugadani
reviewed
Mar 25, 2026
Contributor
bugadani
left a comment
bugadani
left a comment
There was a problem hiding this comment.
No real concerns, a missing signal here, a missing function there, and a bit of formatting to be corrected before merging.
bugadani
approved these changes
Mar 25, 2026
Member
Author
|
Bro... PS: hahaha I KNEW complaining works - started right after I commented 😆 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5222
HIL currently doesn't feel good, but the test itself goes smoothly