Conversation
|
Download the artifacts for this pull request: |
3 tasks
c114ac4 to
917ad1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant updates to the
ESP32C5ROMclass insrc/targets/esp32c5.tsto improve feature support, accuracy, and maintainability for the ESP32-C5 chip. The changes include corrections to register shifts and memory maps, expanded key purposes, new hardware feature reporting, and the addition of several new methods for handling keys, SPI connections, and hardware checks. Additionally, the stub flasher binary and metadata for ESP32-C5 have been updated.Key improvements and changes:
1. Hardware register and memory map corrections:
IROMandDROMto accurately reflect the ESP32-C5's architecture. [1] [2] [3]2. Key management enhancements:
KEY_PURPOSESmapping to include new key types such asXTS_AES_128_PSRAM_KEY,ECDSA_KEY_P192, andECDSA_KEY_P384variants, and added a constant forPURPOSE_VAL_XTS_AES128_KEY. [1] [2]getKeyBlockPurpose(reads the purpose of a key block), andisFlashEncryptionKeyValid(checks if a valid AES-128 key is present or forced via key manager).3. Hardware features and checks:
getChipFeaturesto report additional ESP32-C5 features such as IEEE802.15.4, single core + LP core, and 240MHz support.checkSpiConnection(validates SPI pin assignments and warns about USB-Serial/JTAG conflicts),usesUsbJtagSerial(detects if USB-JTAG/Serial is in use), and a placeholder forwatchdogReset.4. Baud rate and crystal frequency handling:
changeBaudto check for crystal frequency mismatches and provide user feedback, improving robustness during flashing.Target specific change baud is not yet defined
5. Stub flasher update:
src/targets/stub_flasher/stub_flasher_32c5.jsonwith a new stub binary (entry,text,data, anddata_startfields) to match the latest ESP32-C5 requirements.These changes collectively improve the ESP32-C5 support in the codebase, making it more accurate, feature-complete, and user-friendly.
Description
Update esp32-c5 to latest esptool stub.
Testing
Manual testing using esp32-c5-devkitc-1 and typescript example
Checklist
Before submitting a Pull Request, please ensure the following: