fix(consume/engine): check if client fails to raise an expected Engine API error #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
added
type:bug
3 tasks
marioevz
approved these changes
Jan 28, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
Thanks so much for debugging and fixing this!
marioevz
pushed a commit
to marioevz/execution-spec-tests
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR adds a missing check for the case of Engine API exceptions.
If the fixture specifies a payload
errorCode, then check that it is indeed raised by the client. If not, fail the test.🔗 Related Issues
InvalidParamsfor requests shorter than 1 byte #1138.✅ Checklist