-
Notifications
You must be signed in to change notification settings - Fork 185
fix(tests): EIP-7685 - raise InvalidParams for requests shorter than 1 byte
#1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
commented
Jan 28, 2025
Member
Author
danceratopz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/prague/eip7685_general_purpose_el_requests/test_request_types.py
Outdated
Show resolved
Hide resolved
2 tasks
Member
|
I think we should:
I'll open a PR to address these. |
Merged
* refactor(tests): EIP-7685: Add invalid cases * refactor(tests): EIP-7685: Remove redundant `test_request_types.py`, remove unused fixtures * small comment * Update tests/prague/eip7685_general_purpose_el_requests/test_deposits_withdrawals_consolidations.py Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: danceratopz <[email protected]>
marioevz
approved these changes
Jan 29, 2025
marioevz
added a commit
to marioevz/execution-spec-tests
that referenced
this pull request
Jan 30, 2025
…n 1 byte (ethereum#1138) * fix(tests): raise `InvalidParams` for requests shorter than 1 byte * Refactor to ethereum#1138 (ethereum#1141) * refactor(tests): EIP-7685: Add invalid cases * refactor(tests): EIP-7685: Remove redundant `test_request_types.py`, remove unused fixtures * small comment * Update tests/prague/eip7685_general_purpose_el_requests/test_deposits_withdrawals_consolidations.py Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: Mario Vega <[email protected]>
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
…n 1 byte (ethereum#1138) * fix(tests): raise `InvalidParams` for requests shorter than 1 byte * Refactor to ethereum#1138 (ethereum#1141) * refactor(tests): EIP-7685: Add invalid cases * refactor(tests): EIP-7685: Remove redundant `test_request_types.py`, remove unused fixtures * small comment * Update tests/prague/eip7685_general_purpose_el_requests/test_deposits_withdrawals_consolidations.py Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: Mario Vega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flagged by the reth team.
🗒️ Description
This PR additionally raises
EngineAPIError.InvalidParamsfor the following 2 test cases in the [email protected] release:These tests have a request of type
0x03which does not contain data. As such, they are 1 byte in length and according to the API spec:the Engine API call should raise
EngineAPIError.InvalidParams(they currently do correctly raise aBlockException.INVALID_REQUESTS).🔗 Related Issues
#1097
✅ Checklist
All: Added an entry to CHANGELOG.md.skipped But should be added to release notes.