Slashable vote data cleanup #1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i also found a bug in the test code so good thing you took a second look! and while normally we should add a test for the broken test case, i want to discuss updating the BLS spec before making any further changes |
pipermerriam
approved these changes
Jan 5, 2019
djrtwo
approved these changes
Jan 7, 2019
pipermerriam
reviewed
Jan 7, 2019
There was a problem hiding this comment.
@hwwhww 👍 from me structurally, relying on you to review correctness.
hwwhww
approved these changes
Jan 8, 2019
|
@hwwhww i made those updates :) the related tests pass locally -- trying to sort why the CI failed... seems unrelated to these edits... |
|
@ralexstokes thanks! 👍 |
The previous implementation was using the `domain_type` as the `domain` when it should in fact be the value calculated by `get_domain`.
This change is more in line with how this functionality will ultimately be used so we want to route our query through the `BeaconState`.
ralexstokes
force-pushed
the
slashable-vote-data-cleanup
branch
from
c8a2bbe to
569849c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fixes #1696.
How was it fixed?
Implemented the suggested changes from the review here: #1658 (review)
Cute Animal Picture