fix(rpc): Fix CMake header-only library targets for velox_rpc_types and velox_rpc_client (#16748)#16748
Closed
zhichenxu-meta wants to merge 1 commit intofacebookincubator:mainfrom
Closed
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
zhichenxu-meta
force-pushed
the
export-D96329737
branch
2 times, most recently
from
58c9198 to
af0f880
Compare
xiaoxmeng
approved these changes
Mar 12, 2026
zhichenxu-meta
added a commit
to zhichenxu-meta/velox
that referenced
this pull request
Mar 12, 2026
…nd velox_rpc_client (facebookincubator#16748) Summary: facebookincubator#16748 velox_rpc_types and velox_rpc_client are header-only libraries (no .cpp source files). Without the INTERFACE keyword, CMake cannot determine the linker language, causing a build failure on macOS: CMake Error: CMake can not determine linker language for target: velox_rpc_types Mark both as INTERFACE libraries and use INTERFACE linkage for velox_rpc_client dependencies. Reviewed By: xiaoxmeng Differential Revision: D96329737
zhichenxu-meta
force-pushed
the
export-D96329737
branch
from
af0f880 to
5486aa4
Compare
zhichenxu-meta
added a commit
to zhichenxu-meta/velox
that referenced
this pull request
Mar 12, 2026
…nd velox_rpc_client (facebookincubator#16748) Summary: facebookincubator#16748 velox_rpc_types and velox_rpc_client are header-only libraries (no .cpp source files). Without the INTERFACE keyword, CMake cannot determine the linker language, causing a build failure on macOS: CMake Error: CMake can not determine linker language for target: velox_rpc_types Mark both as INTERFACE libraries and use INTERFACE linkage for velox_rpc_client dependencies. Reviewed By: xiaoxmeng Differential Revision: D96329737
zhichenxu-meta
force-pushed
the
export-D96329737
branch
from
5486aa4 to
64329b3
Compare
zhichenxu-meta
added a commit
to zhichenxu-meta/velox
that referenced
this pull request
Mar 12, 2026
…nd velox_rpc_client (facebookincubator#16748) Summary: facebookincubator#16748 velox_rpc_types and velox_rpc_client are header-only libraries (no .cpp source files). Without the INTERFACE keyword, CMake cannot determine the linker language, causing a build failure on macOS: CMake Error: CMake can not determine linker language for target: velox_rpc_types Mark both as INTERFACE libraries and use INTERFACE linkage for velox_rpc_client dependencies. Reviewed By: xiaoxmeng Differential Revision: D96329737
zhichenxu-meta
force-pushed
the
export-D96329737
branch
from
64329b3 to
16634ee
Compare
zhichenxu-meta
added a commit
to zhichenxu-meta/velox
that referenced
this pull request
Mar 12, 2026
…nd velox_rpc_client (facebookincubator#16748) Summary: facebookincubator#16748 velox_rpc_types and velox_rpc_client are header-only libraries (no .cpp source files). Without the INTERFACE keyword, CMake cannot determine the linker language, causing a build failure on macOS: CMake Error: CMake can not determine linker language for target: velox_rpc_types Mark both as INTERFACE libraries and use INTERFACE linkage for velox_rpc_client dependencies. Reviewed By: xiaoxmeng Differential Revision: D96329737
zhichenxu-meta
force-pushed
the
export-D96329737
branch
from
16634ee to
905ce5f
Compare
zhichenxu-meta
added a commit
to zhichenxu-meta/velox
that referenced
this pull request
Mar 12, 2026
…nd velox_rpc_client (facebookincubator#16748) Summary: Pull Request resolved: facebookincubator#16748 facebookincubator#16748 velox_rpc_types and velox_rpc_client are header-only libraries (no .cpp source files). Without the INTERFACE keyword, CMake cannot determine the linker language, causing a build failure on macOS: CMake Error: CMake can not determine linker language for target: velox_rpc_types Mark both as INTERFACE libraries and use INTERFACE linkage for velox_rpc_client dependencies. Reviewed By: xiaoxmeng Differential Revision: D96329737
zhichenxu-meta
force-pushed
the
export-D96329737
branch
from
905ce5f to
cbe8952
Compare
|
@zhichenxu-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96329737. |
zhichenxu-meta
added a commit
to zhichenxu-meta/velox
that referenced
this pull request
Mar 12, 2026
…nd velox_rpc_client (facebookincubator#16748) Summary: facebookincubator#16748 velox_rpc_types and velox_rpc_client are header-only libraries (no .cpp source files). Without the INTERFACE keyword, CMake cannot determine the linker language, causing a build failure on macOS: CMake Error: CMake can not determine linker language for target: velox_rpc_types Mark both as INTERFACE libraries and use INTERFACE linkage for velox_rpc_client dependencies. Reviewed By: xiaoxmeng Differential Revision: D96329737
zhichenxu-meta
force-pushed
the
export-D96329737
branch
from
cbe8952 to
4b1e56f
Compare
zhichenxu-meta
added a commit
to zhichenxu-meta/velox
that referenced
this pull request
Mar 12, 2026
…nd velox_rpc_client (facebookincubator#16748) Summary: facebookincubator#16748 velox_rpc_types and velox_rpc_client are header-only libraries (no .cpp source files). Without the INTERFACE keyword, CMake cannot determine the linker language, causing a build failure on macOS: CMake Error: CMake can not determine linker language for target: velox_rpc_types Mark both as INTERFACE libraries and use INTERFACE linkage for velox_rpc_client dependencies. Reviewed By: xiaoxmeng Differential Revision: D96329737
zhichenxu-meta
force-pushed
the
export-D96329737
branch
from
4b1e56f to
51c483f
Compare
…nd velox_rpc_client (facebookincubator#16748) Summary: facebookincubator#16748 velox_rpc_types and velox_rpc_client are header-only libraries (no .cpp source files). Without the INTERFACE keyword, CMake cannot determine the linker language, causing a build failure on macOS: CMake Error: CMake can not determine linker language for target: velox_rpc_types Mark both as INTERFACE libraries and use INTERFACE linkage for velox_rpc_client dependencies. Reviewed By: xiaoxmeng Differential Revision: D96329737
meta-codesync
bot
changed the title
zhichenxu-meta
force-pushed
the
export-D96329737
branch
from
51c483f to
a3851b0
Compare
|
This pull request has been merged in 87c8f7e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#16748
velox_rpc_types and velox_rpc_client are header-only libraries (no .cpp
source files). Without the INTERFACE keyword, CMake cannot determine the
linker language, causing a build failure on macOS:
CMake Error: CMake can not determine linker language for target: velox_rpc_types
Mark both as INTERFACE libraries and use INTERFACE linkage for
velox_rpc_client dependencies.
Reviewed By: xiaoxmeng
Differential Revision: D96329737