Skip to content

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Nov 21, 2025

This fixes main branch part of flutter/flutter#176433

The work left is adjusting cocoon to also run this check in release branch

The high level view of this pr.

  1. Move ci_config.yaml and pending changelog parsing into RepositoryPackage and the parsed results are exposed as a getter method so that it can be shared between branch_for_release, repo_package_info_check, and version_check
  2. The format error of ci_config.yaml and changelog files are reported in repo_package_info_check. The other 2 assume they are correct formatted and throw directly if they are not.
  3. update the version_check to be able to handle batch release package

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@chunhtai chunhtai changed the title [ci] Adds repo checks for batch release [ci] Adds repo checks in main branch for batch release Nov 21, 2025
@github-actions github-actions bot added p: go_router triage-framework Should be looked at in framework triage labels Nov 21, 2025
}
}
} else {
switch (versionState) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no change to this part, just put the original code into the else case

expect(
output,
containsAll(<Matcher>[
contains(' Checking ci_config.yaml...'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed additional print to be more in sync with all the check in repo_package_info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: go_router triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant