-
Notifications
You must be signed in to change notification settings - Fork 4
NEW: @W-18395429@ Add SLDS Config Settings and Rules to ESLint (v9) #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randi274
commented
Aug 14, 2025
...er-eslint-engine/test/test-data/workspaceWithFlatConfigJs/a-config-file-that-uses-ignores.js
Show resolved
Hide resolved
randi274
commented
Aug 14, 2025
randi274
commented
Aug 14, 2025
randi274
commented
Aug 14, 2025
packages/code-analyzer-eslint-engine/src/missing-types-for-dependencies.d.ts
Show resolved
Hide resolved
48288df to
37586ad
Compare
stephen-carter-at-sf
requested changes
Aug 15, 2025
...ages/code-analyzer-eslint-engine/test/test-data/workspaceWithFlatConfigMjs/eslint.config.mjs
Outdated
Show resolved
Hide resolved
stephen-carter-at-sf
requested changes
Aug 15, 2025
stephen-carter-at-sf
requested changes
Aug 15, 2025
jfeingold35
reviewed
Aug 15, 2025
...ages/code-analyzer-eslint-engine/test/test-data/workspaceWithFlatConfigMjs/eslint.config.mjs
Outdated
Show resolved
Hide resolved
stephen-carter-at-sf
approved these changes
Aug 15, 2025
f929a57 to
acfd26a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
disable_slds_base_configto turn off these new SLDS ruleshtml(.html, .htm, and .cmp) to be used for rule discovery of particular files